| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | several attstattarget-related improvements |
| Date: | 2023-06-28 14:52:27 |
| Message-ID: | d6069765-5971-04d3-c10d-e4f7b2e9c459@eisentraut.org |
| Views: | Whole Thread |Raw Message |Download mbox |Resend email |
| Lists: | pgsql-hackers |
Here are a few patches related to attstattarget:
- 0001: Change type of pg_statistic_ext.stxstattarget, to match
attstattarget. Maybe this should go into PG16, for consistency?
- 0002: Add macro for maximum statistics target, instead of hardcoding
it everywhere.
- 0003: Take pg_attribute out of VacAttrStats. This simplifies some
code, especially for extended statistics, which had to have weird
workarounds.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Change-type-of-pg_statistic_ext.stxstattarget.patch | text/plain | 2.9 KB |
| 0002-Add-macro-for-maximum-statistics-target.patch | text/plain | 5.2 KB |
| 0003-Take-pg_attribute-out-of-VacAttrStats.patch | text/plain | 14.6 KB |
| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: several attstattarget-related improvements |
| Date: | 2023-06-28 21:30:11 |
| Message-ID: | 982aade8-f862-f62b-f628-f93432ab1ec6@enterprisedb.com |
| Views: | Whole Thread |Raw Message |Download mbox |Resend email |
| Lists: | pgsql-hackers |
On 6/28/23 16:52, Peter Eisentraut wrote:
> Here are a few patches related to attstattarget:
>
> - 0001: Change type of pg_statistic_ext.stxstattarget, to match
> attstattarget. Maybe this should go into PG16, for consistency?
>
> - 0002: Add macro for maximum statistics target, instead of hardcoding
> it everywhere.
>
> - 0003: Take pg_attribute out of VacAttrStats. This simplifies some
> code, especially for extended statistics, which had to have weird
> workarounds.
+1 to all three patches
Not sure about 0001 vs PG16, it'd require catversion bump.
regards
--
Tomas Vondra
EnterpriseDB:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: several attstattarget-related improvements |
| Date: | 2023-06-28 22:10:09 |
| Message-ID: | 1332450.1687990209@sss.pgh.pa.us |
| Views: | Whole Thread |Raw Message |Download mbox |Resend email |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> On 6/28/23 16:52, Peter Eisentraut wrote:
>> - 0001: Change type of pg_statistic_ext.stxstattarget, to match
>> attstattarget. Maybe this should go into PG16, for consistency?
> Not sure about 0001 vs PG16, it'd require catversion bump.
Yeah, past beta1 I think we should be conservative about bumping
catversion. Suggest you hold this for now, and if we find some
more-compelling reason for a catversion bump in v16, we can sneak
it in at that time. Otherwise, I won't cry if it waits for v17.
regards, tom lane
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: several attstattarget-related improvements |
| Date: | 2023-07-03 05:26:12 |
| Message-ID: | 5a533329-39ad-3fa2-ee4b-c48996ae0940@eisentraut.org |
| Views: | Whole Thread |Raw Message |Download mbox |Resend email |
| Lists: | pgsql-hackers |
On 28.06.23 23:30, Tomas Vondra wrote:
> On 6/28/23 16:52, Peter Eisentraut wrote:
>> Here are a few patches related to attstattarget:
>>
>> - 0001: Change type of pg_statistic_ext.stxstattarget, to match
>> attstattarget. Maybe this should go into PG16, for consistency?
>>
>> - 0002: Add macro for maximum statistics target, instead of hardcoding
>> it everywhere.
>>
>> - 0003: Take pg_attribute out of VacAttrStats. This simplifies some
>> code, especially for extended statistics, which had to have weird
>> workarounds.
>
> +1 to all three patches
>
> Not sure about 0001 vs PG16, it'd require catversion bump.
committed (to PG17 for now)