Linux Kernel patch submission checklist

Here are some basic things that developers should do if they want to see theirkernel patch submissions accepted more quickly.

These are all above and beyond the documentation that is provided inDocumentation/process/submitting-patches.rstand elsewhere regarding submitting Linux kernel patches.

  1. If you use a facility then #include the file that defines/declaresthat facility. Don’t depend on other header files pulling in onesthat you use.
  2. Builds cleanly:
  1. with applicable or modifiedCONFIG options=y,=m, and=n. Nogcc warnings/errors, no linker warnings/errors.
  2. Passesallnoconfig,allmodconfig
  3. Builds successfully when usingO=builddir

  1. Builds on multiple CPU architectures by using local cross-compile toolsor some other build farm.

  2. ppc64 is a good architecture for cross-compilation checking because ittends to useunsignedlong for 64-bit quantities.

  3. Check your patch for general style as detailed inDocumentation/process/coding-style.rst.Check for trivial violations with the patch style checker prior tosubmission (scripts/checkpatch.pl).You should be able to justify all violations that remain inyour patch.

  4. Any new or modifiedCONFIG options do not muck up the config menu anddefault to off unless they meet the exception criteria documented inDocumentation/kbuild/kconfig-language.rst Menu attributes: default value.

  5. All newKconfig options have help text.

  6. Has been carefully reviewed with respect to relevantKconfigcombinations. This is very hard to get right with testing – brainpowerpays off here.

  7. Check cleanly with sparse.

  8. Usemakecheckstack andmakenamespacecheck and fix any problemsthat they find.

    Note

    checkstack does not point out problems explicitly,but any one function that uses more than 512 bytes on the stack is acandidate for change.

  9. Includekernel-doc to document global kernel APIs.(Not required for static functions, but OK there also.) Usemakehtmldocs ormakepdfdocs to check thekernel-doc and fix any issues.

  10. Has been tested withCONFIG_PREEMPT,CONFIG_DEBUG_PREEMPT,CONFIG_DEBUG_SLAB,CONFIG_DEBUG_PAGEALLOC,CONFIG_DEBUG_MUTEXES,CONFIG_DEBUG_SPINLOCK,CONFIG_DEBUG_ATOMIC_SLEEP,CONFIG_PROVE_RCU andCONFIG_DEBUG_OBJECTS_RCU_HEAD allsimultaneously enabled.

  11. Has been build- and runtime tested with and withoutCONFIG_SMP andCONFIG_PREEMPT.

  1. All codepaths have been exercised with all lockdep features enabled.

  2. All new/proc entries are documented underDocumentation/

  3. All new kernel boot parameters are documented inDocumentation/admin-guide/kernel-parameters.rst.

  4. All new module parameters are documented withMODULE_PARM_DESC()

  5. All new userspace interfaces are documented inDocumentation/ABI/.SeeDocumentation/ABI/README for more information.Patches that change userspace interfaces should be CCed tolinux-api@vger.kernel.org.

  6. Check that it all passesmakeheaders_check.

  7. Has been checked with injection of at least slab and page-allocationfailures. SeeDocumentation/fault-injection/.

    If the new code is substantial, addition of subsystem-specific faultinjection might be appropriate.

  8. Newly-added code has been compiled withgcc-W (usemakeEXTRA_CFLAGS=-W). This will generate lots of noise, but is goodfor finding bugs like “warning: comparison between signed and unsigned”.

  9. Tested after it has been merged into the -mm patchset to make surethat it still works with all of the other queued patches and variouschanges in the VM, VFS, and other subsystems.

  10. All memory barriers {e.g.,barrier(),rmb(),wmb()} need acomment in the source code that explains the logic of what they are doingand why.

  11. If any ioctl’s are added by the patch, then also updateDocumentation/userspace-api/ioctl/ioctl-number.rst.

  12. If your modified source code depends on or uses any of the kernelAPIs or features that are related to the followingKconfig symbols,then test multiple builds with the relatedKconfig symbols disabledand/or=m (if that option is available) [not all of these at thesame time, just various/random combinations of them]:

    CONFIG_SMP,CONFIG_SYSFS,CONFIG_PROC_FS,CONFIG_INPUT,CONFIG_PCI,CONFIG_BLOCK,CONFIG_PM,CONFIG_MAGIC_SYSRQ,CONFIG_NET,CONFIG_INET=n (but latter withCONFIG_NET=y).