NotificationsYou must be signed in to change notification settings
Fork3.3k
Star11.5k

Iceberg variant type read support#25419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

anusudarsan wants to merge3 commits intotrinodb:masterfromanusudarsan:anu/iceberg-variant-read

Closed

Iceberg variant type read support#25419

anusudarsan wants to merge3 commits intotrinodb:masterfromanusudarsan:anu/iceberg-variant-read

Conversation

Copy link

Member

anusudarsan commentedMar 25, 2025•
edited
Loading

Description

Read support for parquet format -#24538

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

##Section* Fix some things. ({issue}`issuenumber`)

cla-botbot added the cla-signed label

Mar 25, 2025

github-actionsbot added the icebergIceberg connector label

Mar 25, 2025

anusudarsan force-pushed theanu/iceberg-variant-read branch 3 times, most recently from8f0693a to86c4a0aCompare

March 26, 2025 13:59

anusudarsan requested a review fromebyhr

March 26, 2025 15:55

anusudarsan force-pushed theanu/iceberg-variant-read branch from86c4a0a to8b01c35Compare

March 26, 2025 16:00

Copy link

Member

ebyhr commentedApr 1, 2025

@anusudarsan Is this PR ready for review except for the 1st commit? Could you change the status to non-draft if so?

anusudarsan marked this pull request as ready for review

April 1, 2025 14:30

anusudarsan changed the title~~[draft] Iceberg variant type read support~~Iceberg variant type read support

Apr 1, 2025

Copy link

MemberAuthor

anusudarsan commentedApr 1, 2025

@ebyhr yes please review. This is based of the 1.9.0 version which is still in progress#25331

ebyhr reviewed

Apr 8, 2025

View reviewed changes

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ColumnIdentity.java

		@@ -35,6 +35,7 @@
		import static io.trino.plugin.iceberg.ColumnIdentity.TypeCategory.MAP;
		import static io.trino.plugin.iceberg.ColumnIdentity.TypeCategory.PRIMITIVE;
		import static io.trino.plugin.iceberg.ColumnIdentity.TypeCategory.STRUCT;
		import static io.trino.plugin.iceberg.ColumnIdentity.TypeCategory.VARIANT;