Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] Add support for periodically refreshing dynamic catalogs from the CatalogStore#25389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ppaglilla
Copy link

Description

Proposal to add support for Trino installations using dynamic catalogs to periodically refresh catalogs from the configuredCatalogStore. It allows Trino to periodically list the catalogs available in theCatalogStore and add/remove/update the available catalogs accordingly.

The objective of this proposed change is to allow administrators to externally manage dynamic catalogs and have Trino periodically sync to their configuration, rather than needing to push catalog changes to Trino throughCREATE/DROP CATALOG statements.

Catalog refreshes are disabled by default and can be enabled through thecatalog.refresh.enabled configuration property. The refresh interval defaults to 60 seconds and can be configured through thecatalog.refresh.refresh-interval

Example configuration:

catalog.management=dynamiccatalog.refresh.enabled=truecatalog.refresh.refresh-interval=60scatalog.store=my_catalog_store

I would love to hear feedback on whether this change is welcome and on the approach itself. I would also appreciate any recommendations on how to effectively test the change.

Additional context and related issues

Catalog refreshes are implemented in theCoordinatorDynamicCatalogManager::refreshCatalogs() method. The approach is to list the catalogs from the catalog store, compare them to the currently active catalogs and determine the catalogs that were added, removed or updated. With that information, update the catalog state accordingly.

Catalog refreshing is triggered by theCatalogRefreshTask, which works very similarly to the existingCatalogPruneTask.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-botcla-bot
Copy link

cla-botbot commentedMar 23, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign ourContributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA tocla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, seehttps://github.com/trinodb/cla

@ebyhr
Copy link
Member

@cla-bot check

@cla-botcla-bot
Copy link

cla-botbot commentedApr 6, 2025

The cla-bot has been summoned, and re-checked this pull request!

Adds support for Trino installations using dynamic catalogs to periodically refreshcatalogs from the configured CatalogStore. Catalog refreshes are disabled by default.The refresh interval defaults to 60 seconds.
@ppaglillappaglillaforce-pushed theppaglilla/dynamic-catalog-refresh branch from69b6e81 to11917a6CompareApril 8, 2025 21:41
@github-actionsGitHub Actions
Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actionsGitHub Actions
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ppaglilla@ebyhr

[8]ページ先頭

©2009-2025 Movatter.jp