- Notifications
You must be signed in to change notification settings - Fork3.3k
Test with JDK 25+28-ea-beta#25355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5c661b1 to990c9d0Comparewendigo commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
f463be3 to29af6d5CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the Java version used by Trino’s runtime checks and CI configurations to test against a newer JDK early-access release.
- The required Java version in TrinoSystemRequirements is updated from "23" to "25-beta+14-ea".
- The CI workflows and setup action are updated to use "25-ea" as the default Java version for consistency.
Reviewed Changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java | Updated required Java version for runtime checks. |
| .github/workflows/ci.yml | Updated Java version references in workflow jobs. |
| .github/actions/setup/action.yml | Updated default Java version for setup action. |
Files not reviewed (7)
- core/jdk/current: Language not supported
- core/jdk/temurin/jdk-24+36/arm64: Language not supported
- core/jdk/temurin/jdk-24+36/ppc64le: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/amd64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/arm64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/ppc64le: Language not supported
- testing/trino-product-tests/pom.xml: Language not supported
Comments suppressed due to low confidence (2)
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java:103
- The required Java version is set to "25-beta+14-ea", which differs in format from the "25-ea" used in other configurations. Please verify if this discrepancy is intentional or update the version strings for consistency.
Version required = Version.parse("25-beta+14-ea");.github/workflows/ci.yml:190
- The java-version in this section is updated to '24', which may be inconsistent with the '25-ea' used elsewhere in the CI configuration. Consider updating it to '25-ea' for consistency.
java-version: '24'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the project's Java version requirements to test with a newer JDK.
- Update the required Java version in TrinoSystemRequirements.java to "25-beta+14-ea".
- Modify the CI workflow and GitHub actions to use "25-ea" as the Java version.
Reviewed Changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java | Updated minimum required Java version. |
| .github/workflows/ci.yml | Adjusted test matrix to use updated Java version settings. |
| .github/actions/setup/action.yml | Modified default Java version for setup. |
Files not reviewed (8)
- core/jdk/current: Language not supported
- core/jdk/temurin/jdk-24+36/arm64: Language not supported
- core/jdk/temurin/jdk-24+36/ppc64le: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/amd64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/arm64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/ppc64le: Language not supported
- pom.xml: Language not supported
- testing/trino-product-tests/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java:103
- Ensure the required Java version string is consistent across the project. The SystemRequirements file uses "25-beta+14-ea", while the CI workflow and GitHub actions set the Java version to "25-ea".
Version required = Version.parse("25-beta+14-ea");0918302 tod5b73bbComparewendigo commentedApr 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
trino-main failing due to new timezone:https://github.com/openjdk/jdk/pull/24234/files (requires joda-time update to 2025b) |
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
08f47cc to69a829aCompareThis pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: