Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use batched block builders in MergePages#25289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raunaqmorarka merged 2 commits intotrinodb:masterfromraunaqmorarka:merge-pages
Apr 4, 2025

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarkaraunaqmorarka commentedMar 12, 2025
edited
Loading

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

##Section* Fix some things. ({issue}`issuenumber`)

@wendigo
Copy link
Contributor

@raunaqmorarka I think I've fixed remaining failures

@wendigowendigo requested a review fromlosipiukApril 2, 2025 15:34
@raunaqmorarkaraunaqmorarka marked this pull request as ready for reviewApril 2, 2025 15:40
@raunaqmorarkaraunaqmorarka requested a review fromdainApril 2, 2025 15:41
@starburstdata-automation
Copy link

starburstdata-automation commentedApr 2, 2025
edited
Loading

Started benchmark workflow for this PR with test type =iceberg/sf1000_parquet_part.

Building Trino finished with status:success
Benchmark finished with status:success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message:NO Regression found.
Benchmark Comparison to the closest run from Master:Report

@wendigo
Copy link
Contributor

wendigo commentedApr 2, 2025
edited
Loading

There is only one, related failure in thedelta-lake-oss suite but it seems to be a bug in delta:

tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20250402_155338_00527_3sfjm): class io.trino.spi.block.RowBlock cannot be cast to class io.trino.spi.block.IntArrayBlock (io.trino.spi.block.RowBlock and io.trino.spi.block.IntArrayBlock are in unnamed module of loader 'app')tests               | at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)tests               | at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)tests               | at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:54)tests               | at dev.failsafe.Functions.lambda$toCtxSupplier$11(Functions.java:243)tests               | at dev.failsafe.Functions.lambda$get$0(Functions.java:46)tests               | at dev.failsafe.internal.RetryPolicyExecutor.lambda$apply$0(RetryPolicyExecutor.java:74)tests               | at dev.failsafe.SyncExecutionImpl.executeSync(SyncExecutionImpl.java:187)tests               | at dev.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)tests               | at dev.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:112)tests               | at io.trino.tests.product.utils.QueryExecutors$1.executeQuery(QueryExecutors.java:54)tests               | at io.trino.tests.product.deltalake.TestDeltaLakeColumnMappingMode.testColumnMappingModeAddColumn(TestDeltaLakeColumnMappingMode.java:517)tests               | at io.trino.tests.product.deltalake.TestDeltaLakeColumnMappingMode.testColumnMappingModeIdAddColumn(TestDeltaLakeColumnMappingMode.java:469)tests               | at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)tests               | at java.base/java.lang.reflect.Method.invoke(Method.java:565)tests               | at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)tests               | at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)tests               | at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)tests               | at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)tests               | at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)tests               | at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)tests               | at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1095)tests               | at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:619)tests               | at java.base/java.lang.Thread.run(Thread.java:1447)tests               | Caused by: java.sql.SQLException: Query failed (#20250402_155338_00527_3sfjm): class io.trino.spi.block.RowBlock cannot be cast to class io.trino.spi.block.IntArrayBlock (io.trino.spi.block.RowBlock and io.trino.spi.block.IntArrayBlock are in unnamed module of loader 'app')tests               | at io.trino.jdbc.ResultUtils.resultsException(ResultUtils.java:33)tests               | at io.trino.jdbc.AsyncResultIterator.lambda$new$1(AsyncResultIterator.java:93)tests               | at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:545)tests               | at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328)tests               | ... 3 moretests               | Suppressed: java.lang.Exception: Query: SELECT a_number, another_varchar, a_array[1], a_map['key'], a_row.x FROM delta.default.test_dl_column_mapping_mode_add_column_m7qgxggng1tests               | at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:136)tests               | at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:112)tests               | at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)tests               | at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:54)tests               | at dev.failsafe.Functions.lambda$toCtxSupplier$11(Functions.java:243)tests               | at dev.failsafe.Functions.lambda$get$0(Functions.java:46)tests               | at dev.failsafe.internal.RetryPolicyExecutor.lambda$apply$0(RetryPolicyExecutor.java:74)tests               | at dev.failsafe.SyncExecutionImpl.executeSync(SyncExecutionImpl.java:187)tests               | at dev.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)tests               | at dev.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:112)tests               | at io.trino.tests.product.utils.QueryExecutors$1.executeQuery(QueryExecutors.java:54)tests               | at io.trino.tests.product.deltalake.TestDeltaLakeColumnMappingMode.testColumnMappingModeAddColumn(TestDeltaLakeColumnMappingMode.java:517)tests               | at io.trino.tests.product.deltalake.TestDeltaLakeColumnMappingMode.testColumnMappingModeIdAddColumn(TestDeltaLakeColumnMappingMode.java:469)tests               | at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)tests               | at java.base/java.lang.reflect.Method.invoke(Method.java:565)tests               | at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)tests               | at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)tests               | at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)tests               | at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)tests               | at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)tests               | at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)tests               | ... 3 more
2025-04-02T15:53:46.4438841Z tests               | Caused by: java.lang.ClassCastException: class io.trino.spi.block.RowBlock cannot be cast to class io.trino.spi.block.IntArrayBlock (io.trino.spi.block.RowBlock and io.trino.spi.block.IntArrayBlock are in unnamed module of loader 'app')2025-04-02T15:53:46.4440816Z tests               | at io.trino.spi.block.IntArrayBlockBuilder.append(IntArrayBlockBuilder.java:74)2025-04-02T15:53:46.4441946Z tests               | at io.trino.spi.block.IntArrayBlockBuilder.appendRange(IntArrayBlockBuilder.java:127)2025-04-02T15:53:46.4443633Z tests               | at io.trino.operator.project.MergePages$MergePagesTransformation.appendRawBlock(MergePages.java:223)2025-04-02T15:53:46.4444871Z tests               | at io.trino.operator.project.MergePages$MergePagesTransformation.appendPage(MergePages.java:211)2025-04-02T15:53:46.4445754Z tests               | at io.trino.operator.project.MergePages$MergePagesTransformation.process(MergePages.java:197)2025-04-02T15:53:46.4446443Z tests               | at io.trino.operator.project.MergePages$MergePagesTransformation.process(MergePages.java:138)2025-04-02T15:53:46.4447089Z tests               | at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:359)2025-04-02T15:53:46.4447752Z tests               | at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:423)2025-04-02T15:53:46.4448420Z tests               | at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:261)2025-04-02T15:53:46.4449274Z tests               | at io.trino.operator.WorkProcessorUtils$BlockingProcess.process(WorkProcessorUtils.java:207)2025-04-02T15:53:46.4449968Z tests               | at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:423)2025-04-02T15:53:46.4450637Z tests               | at io.trino.operator.WorkProcessorUtils.lambda$flatten$0(WorkProcessorUtils.java:317)2025-04-02T15:53:46.4451306Z tests               | at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:359)2025-04-02T15:53:46.4451958Z tests               | at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:423)2025-04-02T15:53:46.4452892Z tests               | at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:261)2025-04-02T15:53:46.4453559Z tests               | at io.trino.operator.WorkProcessorUtils.lambda$processStateMonitor$0(WorkProcessorUtils.java:240)2025-04-02T15:53:46.4454371Z tests               | at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:423)2025-04-02T15:53:46.4455041Z tests               | at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:261)2025-04-02T15:53:46.4455672Z tests               | at io.trino.operator.WorkProcessorUtils.lambda$finishWhen$0(WorkProcessorUtils.java:255)2025-04-02T15:53:46.4456354Z tests               | at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:423)2025-04-02T15:53:46.4457150Z tests               | at io.trino.operator.WorkProcessorSourceOperatorAdapter.getOutput(WorkProcessorSourceOperatorAdapter.java:132)2025-04-02T15:53:46.4457814Z tests               | at io.trino.operator.Driver.processInternal(Driver.java:403)2025-04-02T15:53:46.4458274Z tests               | at io.trino.operator.Driver.lambda$process$0(Driver.java:306)2025-04-02T15:53:46.4458718Z tests               | at io.trino.operator.Driver.tryWithLock(Driver.java:709)2025-04-02T15:53:46.4459143Z tests               | at io.trino.operator.Driver.process(Driver.java:298)2025-04-02T15:53:46.4459592Z tests               | at io.trino.operator.Driver.processForDuration(Driver.java:269)2025-04-02T15:53:46.4460179Z tests               | at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:890)2025-04-02T15:53:46.4460845Z tests               | at io.trino.execution.executor.dedicated.SplitProcessor.run(SplitProcessor.java:77)2025-04-02T15:53:46.4461550Z tests               | at io.trino.execution.executor.dedicated.TaskEntry$VersionEmbedderBridge.lambda$run$0(TaskEntry.java:201)2025-04-02T15:53:46.4462323Z tests               | at io.trino.$gen.Trino_474_114_gc57f9b6____20250402_154414_2.run(Unknown Source)2025-04-02T15:53:46.4462950Z tests               | at io.trino.execution.executor.dedicated.TaskEntry$VersionEmbedderBridge.run(TaskEntry.java:202)2025-04-02T15:53:46.4463631Z tests               | at io.trino.execution.executor.scheduler.FairScheduler.runTask(FairScheduler.java:177)2025-04-02T15:53:46.4464314Z tests               | at io.trino.execution.executor.scheduler.FairScheduler.lambda$submit$0(FairScheduler.java:164)2025-04-02T15:53:46.4464969Z tests               | at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:545)2025-04-02T15:53:46.4465878Z tests               | at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:128)2025-04-02T15:53:46.4466777Z tests               | at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:74)2025-04-02T15:53:46.4467509Z tests               | at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:80)2025-04-02T15:53:46.4468263Z tests               | at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1095)2025-04-02T15:53:46.4469078Z tests               | at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:619)2025-04-02T15:53:46.4469616Z tests               | at java.base/java.lang.Thread.run(Thread.java:1447)

it seems that we are trying to append RowBlock to ArrayBlock (which doesn't make sense at all)

@wendigo
Copy link
Contributor

@ebyhr PTAL

@wendigo
Copy link
Contributor

It fails for bothTestDeltaLakeColumnMappingMode.testColumnMappingModeIdAddColumn andTestDeltaLakeColumnMappingMode.testColumnMappingModeNameAddColumn

@starburstdata-automation
Copy link

starburstdata-automation commentedApr 2, 2025
edited
Loading

Started benchmark workflow for this PR with test type =hive/sf1000_parquet_part.

Building Trino finished with status:success
Benchmark finished with status:success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message:No baseline found.
Benchmark Comparison to the closest run from Master:Report

@github-actionsgithub-actionsbot added the delta-lakeDelta Lake connector labelApr 4, 2025
@raunaqmorarkaraunaqmorarka merged commit6abe647 intotrinodb:masterApr 4, 2025
94 checks passed
@raunaqmorarkaraunaqmorarka deleted the merge-pages branchApril 4, 2025 12:03
@github-actionsgithub-actionsbot added this to the475 milestoneApr 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@wendigowendigowendigo approved these changes

@losipiuklosipiukAwaiting requested review from losipiuk

@daindainAwaiting requested review from dain

@ebyhrebyhrAwaiting requested review from ebyhr

Assignees
No one assigned
Labels
cla-signeddelta-lakeDelta Lake connectorhiveHive connector
Milestone
475
Development

Successfully merging this pull request may close these issues.

3 participants
@raunaqmorarka@wendigo@starburstdata-automation

[8]ページ先頭

©2009-2025 Movatter.jp