- Notifications
You must be signed in to change notification settings - Fork94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Option: Support omitempty#64
Open
freeformz wants to merge1 commit intosamber:masterChoose a base branch fromfreeformz:ffz/OmitEmpty
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This requires changing the underlying type, which *may* be a breaking change.AFAICT there isn't any way to do this with the struct based type, but canbe done with a slice type (or a map, but maps are heavier weight, so chose slice).When the slice is empty (len == 0) it is considered absent, when it has an itemit is considered present.This also allows for creating a value via:`Option[T]{value}`Any values appended to the slice after the first are ignored.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires changing the underlying type, whichmay be a breaking change.
AFAICT there isn't any way to do this with the struct based type, but can be done with a slice type (or a map, but maps are heavier weight, so chose slice).
When the slice is empty (len == 0) it is considered absent, when it has an item it is considered present.
This also allows for creating a value via:
Option[T]{value}
Any values appended to the slice after the first are ignored.