NotificationsYou must be signed in to change notification settings
Fork3.3k
Star23.5k

Don't override ref property when not configured to.#2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

PSpSynedra wants to merge4 commits intoreduxjs:master

base:master

Choose a base branch

fromPSpSynedra:master

Open

Don't override ref property when not configured to.#2252

PSpSynedra wants to merge4 commits intoreduxjs:masterfromPSpSynedra:master

+31 −2

Conversation

Copy link

Contributor

PSpSynedra commentedAug 21, 2025

The current behavior ofconnect is to always pass along a ref property, event when the optionforwardRef was not truthy or preset.

This pull request

corrects this error by only forwarding a ref property when actually configured to.
avoids problems, when accessing the forwarded but alwaysundefined ref.
fixesExternal property ref is always overridden with value undefined #2251

The error in the following use case is also fixed with this pull-request:

import WrappedComponent from '...'function HocComponent(props) {   const [wrapperRef, setRef] = useState(null)   // The current behavior of connect would override the ref!   return <WrappedComponent ref={setRef} {...props} />}export default connect(...)(HocComponent)

NOTE:
My initial intend was to remove the use ofReact.forwardRef(...) completely, but this would have broken the compatibility with React prior to version 19.

Don't override ref property when not configured to.

929920b

Copy link

codesandbox-cibot commentedAug 21, 2025•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

PSpSynedra added2 commits

August 21, 2025 16:26

Adapt test to work with React 18.

a978553

Actually using options forwardRef when testing against React-18.

5ba583b

Copy link

ContributorAuthor

PSpSynedra commentedAug 21, 2025•
edited
Loading

Unfortunately I cannot get the "Test Published Artifact expo (pull_request)" to pass.
When I runyarn install with node-22.18.0 as suggested by some internet search results, my localyarn.lock does not get changed.

Can I run the failing test locally on my machine to fix the issue?
Any suggestions on how to fix this?

PSpSynedra mentioned this pull request

Aug 26, 2025

External property ref is always overridden with value undefined#2251

Open

1 task

Merge branch 'reduxjs:master' into master

27fd687

Copy link

netlifybot commentedSep 15, 2025

✅ Deploy Preview forreact-redux-docs ready!

Name	Link
🔨 Latest commit	`27fd687`
🔍 Latest deploy log	https://app.netlify.com/projects/react-redux-docs/deploys/68c7ade9c0648e000833e342
😎 Deploy Preview	https://deploy-preview-2252--react-redux-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

Labels

None yet

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Don't override ref property when not configured to.#2252

Are you sure you want to change the base?

Don't override ref property when not configured to.#2252