- Notifications
You must be signed in to change notification settings - Fork178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
DOC-4989 added node-js AMR page#1306
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Language LGTM. I did not validate the technical details. Just one question about a possibly superfluous asterisk (cheeky bugger). :)
| @@ -100,7 +100,7 @@ below: | |||
| elapse before a refresh is triggered. For example, a value of 0.75 means the token | |||
| should be refreshed when 75% of its lifetime has elapsed. | |||
| - `retry`: This object specifies the policy to retry refreshing the token if the | |||
| first attempt fails. It has the following fields: | |||
| an error occurs. It has the following fields: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we forgot to remove "the" before "an error occurs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, one minor typo : we forgot to remove "the" before "an error occurs"
DOC-4989
I've worked from the repoREADME file and also incorporated some stuff from the other clients' AMR pages. Any suggestions or corrections are most welcome :-)