Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.1k
Removeroutes-compiler-injected-routes-compilation scripted test as duplicate#13230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| GET /take-bool controllers.Application.takeBool(b: Boolean) | ||
| GET /take-bool-2/:b controllers.Application.takeBool2(b: Boolean) | ||
| GET /take-list controllers.Application.takeList(x: List[Int]) | ||
| GET /take-list-tick-param controllers.Application.takeListTickedParam(`b[]`: List[Int]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case is covered byroutes-compiler-routes-compilation-java
335d689 to33277b5Compare| GET /take-list controllers.Application.takeList(x: List[Int]) | ||
| GET /take-list-tick-param controllers.Application.takeListTickedParam(`b[]`: List[Int]) | ||
| GET /take-java-list controllers.Application.takeJavaList(x: java.util.List[java.lang.Integer]) | ||
| GET /take-ticked-params controllers.Application.takeTickedParams(`b[]`: List[Int], `b%%`: String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case was moved toroutes-compiler-routes-compilation-java
| it("should properly escape the host", function() { | ||
| var data = jsRoutesBadHost.controllers.Application.index(); | ||
| assert(data.absoluteURL().indexOf("'}}};alert(1);a={a:{a:{a:'") >= 0) | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This check was moved toroutes-compiler-routes-compilation
| "use a new instance for each instantiated controller" in new WithApplication() { | ||
| override def running() = { | ||
| route(implicitApp, FakeRequest(GET, "/instance")) must beSome[Future[Result]].like { | ||
| case result => contentAsString(result) must_== "1" | ||
| } | ||
| route(implicitApp, FakeRequest(GET, "/instance")) must beSome[Future[Result]].like { | ||
| case result => contentAsString(result) must_== "1" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This check was moved toroutes-compiler-routes-compilation
StaticRoutesGeneratorwas removed more than 7 years ago (#8049) andInjectedRoutesGeneratorhas become the only possible way. Therefore, I see no reason to have a two very similar scripted tests.After analysing the difference between
routes-compiler-injected-routes-compilationandroutes-compiler-routes-compilationfolders I copied some cases that were not covered byroutes-compiler-routes-compilationand completely removedroutes-compiler-injected-routes-compilation.