Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/odooPublic

[FW][FIX] point_of_sale: update tmpl. attr. values w/o POS access#202607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

fw-bot
Copy link
Contributor

This PR addresses an access rights issue when an Inventory admin, specifically without POS access, tries to edit the variant attributes on a product template.

In its current state, this user will witness an access error related topos.combo.line records when they add or remove an attribute value.

This PR fixes this by introducing.sudo() access when interacting with thepos.combo.line model during this process.

opw-4553416

Forward-Port-Of:#202144

@robodoo
Copy link
Contributor

Pull request status dashboard

@robodoorobodoo added forwardportThis PR was created by @fw-bot conflictThere was an error while creating this forward-port PR labelsMar 19, 2025
@fw-bot
Copy link
ContributorAuthor

@hahu-odoo@caburj cherrypicking of pull request#202144 failed.

stdout:

Auto-merging addons/point_of_sale/models/product.pyCONFLICT (content): Merge conflict in addons/point_of_sale/models/product.pyAuto-merging addons/point_of_sale/tests/__init__.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via@robodoo.

More info athttps://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdooC3POdoo added the OEthe report is linked to a support ticket (opw-...) labelMar 19, 2025
Before this commit, the Inventory admins who did nothave any POS access could not add or remove variantattribute values from the product template form view.This is because of the potential to create or deletePOS combo lines.However, Inventory admins shouldn't need this accessto manage product variants. If a variant is deleted,its combo line will be deleted as well so that itwon't be offered in POS anymore.X-original-commit:ecc4428
@hahu-odoohahu-odooforce-pushed the18.0-17.0-opw-4553416-hahu-424236-fw branch fromac966c5 to2818942CompareMarch 20, 2025 14:34
@hahu-odoo
Copy link
Contributor

Removed my changes toproduct.py because the method I updated no longer exists in >= 18.0. I left the test file to serve as a regression test.

@C3POdooC3POdoo requested review froma team andcaburj and removed request fora teamMarch 20, 2025 14:39
@fw-bot
Copy link
ContributorAuthor

@hahu-odoo@caburj this forward port of#202144 is awaiting action (not merged or closed).

@hahu-odoo
Copy link
Contributor

@robodoo r+

gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull requestMar 31, 2025
Before this commit, the Inventory admins who did nothave any POS access could not add or remove variantattribute values from the product template form view.This is because of the potential to create or deletePOS combo lines.However, Inventory admins shouldn't need this accessto manage product variants. If a variant is deleted,its combo line will be deleted as well so that itwon't be offered in POS anymore.closesodoo/odoo#202607X-original-commit: ecc44289b299c065e413598c5f565c506f7d42f0Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>Signed-off-by: Harrison Hutton (hahu) <hahu@odoo.com>
@fw-botfw-bot deleted the 18.0-17.0-opw-4553416-hahu-424236-fw branchApril 7, 2025 16:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@caburjcaburjAwaiting requested review from caburjcaburj was automatically assigned from odoo/pos

Assignees
No one assigned
Labels
conflictThere was an error while creating this forward-port PRforwardportThis PR was created by @fw-botOEthe report is linked to a support ticket (opw-...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@fw-bot@robodoo@hahu-odoo@C3POdoo
[8]ページ先頭
©2009-2025 Movatter.jp