- Notifications
You must be signed in to change notification settings - Fork28.6k
[FW][FIX] pos_loyalty: remove fixed tax from discount on orders#202355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
fw-bot wants to merge1 commit intoodoo:saas-18.2fromodoo-dev:saas-18.2-16.0-opw-4506550-loyalty_fixed_tax-stpa-423611-fw
Closed
[FW][FIX] pos_loyalty: remove fixed tax from discount on orders#202355
fw-bot wants to merge1 commit intoodoo:saas-18.2fromodoo-dev:saas-18.2-16.0-opw-4506550-loyalty_fixed_tax-stpa-423611-fw
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Steps to reproduce the issue:(Easier to reproduce with demo data)1. Create a Fixed Tax and assign it to a Product2. Open POS session, add Product to Order3. Add a Coupon Code: "10pc" - This code should give a 10% Discount on the Order4. The Discount Line includes the Fixed Tax amount and accounts for more than 10% of the Order TotalExplanation:During the creation of the reward line, the fixed taxes are not excluded from discounts.While it is logical for percentage taxes to be included, as they become part of the discount, fixed taxes are added to the amount.Fix reasoning:The opposite issue was fixed in commitodoo/odoo@534de1e, adapting the code to javascript.opw-4506550X-original-commit:a583857
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info athttps://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo pushed a commit that referenced this pull requestMar 24, 2025
Steps to reproduce the issue:(Easier to reproduce with demo data)1. Create a Fixed Tax and assign it to a Product2. Open POS session, add Product to Order3. Add a Coupon Code: "10pc" - This code should give a 10% Discount on the Order4. The Discount Line includes the Fixed Tax amount and accounts for more than 10% of the Order TotalExplanation:During the creation of the reward line, the fixed taxes are not excluded from discounts.While it is logical for percentage taxes to be included, as they become part of the discount, fixed taxes are added to the amount.Fix reasoning:The opposite issue was fixed in commit534de1e, adapting the code to javascript.opw-4506550closes#202355X-original-commit:a583857Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>Signed-off-by: Robin Engels (roen) <roen@odoo.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
(Easier to reproduce with demo data)
Explanation:
During the creation of the reward line, the fixed taxes are not excluded from discounts. While it is logical for percentage taxes to be included, as they become part of the discount, fixed taxes are added to the amount.
Fix reasoning:
The opposite issue was fixed in commit534de1e, adapting the code to javascript.
opw-4506550
Forward-Port-Of:#202182
Forward-Port-Of:#200175