Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pw hash include argon2#1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hnxfirefly wants to merge2 commits intomaster
base:master
Choose a base branch
Loading
frompwHash-Include-Argon2ID
Open

Conversation

hnxfirefly
Copy link
Collaborator

What is this PR doing?

@sonarqubecloudSonarQubeCloud
Copy link

Quality Gate FailedQuality Gate failed

Failed conditions
4 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extensionSonarQube for IDE

@M4LuZ
Copy link
Collaborator

M4LuZ commentedMar 18, 2025
edited
Loading

While I am very happy to see a new PR I do not see the point of this.
There is a pending PR for a multi-hash implementation that should move forward shortly once dependencies#870 &#1178 are resolved (yes, I know how that sounds, but really!)
It is trivial to add argon2id there if you really want.
That would be better than to do the same again without taking over the improvements done (multi-hash support, documentation, unit tests)

But the main point why Argon2id was not implemented there is that it is still not part of default php installations - as stated by the other PR. Not sure where you get a different impression from?

Seerelated RFC

"Per the discussion onphp/php-src#1997, this feature will be optionally available via the --with-argon2 configure flag."

Or thePHP documentation itself:

"PASSWORD_ARGON2ID - Use the Argon2id hashing algorithm to create the hash. This algorithm is only available if PHP has been compiled with Argon2 support."

In PHP 8.4, the cost parameter of the password_default/password_bcrypt algorithm has changed from 10 to 12.
But it is still bcrypt by default.
RFC for that here

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hnxfirefly@M4LuZ

[8]ページ先頭

©2009-2025 Movatter.jp