Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: use version.py for versioning, avoid issues with discovering version via get_distribution#288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
crwilcox merged 7 commits intomasterfromguard-get-distribution
Oct 6, 2020

Conversation

@crwilcox
Copy link
Contributor

No description provided.

@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelOct 6, 2020
@crwilcox
Copy link
ContributorAuthor

As it is a bit more robust, I addedversion.py to google-cloud-storage

@tseaver
Copy link
Contributor

@crwilcox Needs agit add google/cloud/storage/version.py.

crwilcox reacted with thumbs up emoji

@crwilcox
Copy link
ContributorAuthor

crwilcox commentedOct 6, 2020
edited
Loading

Test failures seem unrelated to me?

_______________________________________________________________ TestClient.test_lookup_bucket_with_metageneration_match ________________________________________________________________self = <tests.unit.test_client.TestClient testMethod=test_lookup_bucket_with_metageneration_match>    def test_lookup_bucket_with_metageneration_match(self):        from google.cloud.storage.bucket import Bucket        PROJECT = "PROJECT"        CREDENTIALS = _make_credentials()        METAGENERATION_NUMBER = 6        client = self._make_one(project=PROJECT, credentials=CREDENTIALS)        BUCKET_NAME = "bucket-name"        URI1 = "/".join(            [                client._connection.API_BASE_URL,                "storage",                client._connection.API_VERSION,                "b",                "%s?projection=noAcl&ifMetagenerationMatch=%s"                % (BUCKET_NAME, METAGENERATION_NUMBER),            ]        )        URI2 = "/".join(            [                client._connection.API_BASE_URL,                "storage",                client._connection.API_VERSION,                "b",                "%s?ifMetagenerationMatch=%s&projection=noAcl"                % (BUCKET_NAME, METAGENERATION_NUMBER),            ]        )        data = {"name": BUCKET_NAME}        http = _make_requests_session([_make_json_response(data)])        client._http_internal = http        bucket = client.lookup_bucket(            BUCKET_NAME, if_metageneration_match=METAGENERATION_NUMBER        )        self.assertIsInstance(bucket, Bucket)        self.assertEqual(bucket.name, BUCKET_NAME)        http.request.assert_called_once_with(            method="GET",            url=mock.ANY,            data=mock.ANY,            headers=mock.ANY,            timeout=self._get_default_timeout(),        )        _, kwargs = http.request.call_args>       self.assertIn(kwargs.get("url"), (URI1, URI2))E       AssertionError: 'https://storage.googleapis.com/storage/v1/b/bucket-name?projection=noAcl&ifMetagenerationMatch=6&prettyPrint=false' not found in ('https://storage.googleapis.com/storage/v1/b/bucket-name?projection=noAcl&ifMetagenerationMatch=6', 'https://storage.googleapis.com/storage/v1/b/bucket-name?ifMetagenerationMatch=6&projection=noAcl')tests/unit/test_client.py:663: AssertionError

Seems prettyPrint is showing up? Confirmed same failures on master.@andrewsg

@crwilcoxcrwilcox changed the titlefix: harden version data gathering against DistributionNotFoundfix: use version.py for versioning, avoid issues with discovering version via get_distributionOct 6, 2020
@tseaver
Copy link
Contributor

tseaver commentedOct 6, 2020
edited
Loading

@crwilcox&prettyPrint=False got added to URLs viahttps://www.github.com/googleapis/python-cloud-core/pull/28.

@tseaver
Copy link
Contributor

tseaver commentedOct 6, 2020
edited
Loading

We need to pull in@tswast's changes from#277 to get the tests to pass on latestgoogle-cloud-core.

@tseaver
Copy link
Contributor

@crwilcox I just merged#277 to fix the tests onmaster.

@crwilcoxcrwilcox merged commitfcd1c4f intomasterOct 6, 2020
@tseavertseaver deleted the guard-get-distribution branchAugust 24, 2021 18:07
cojenco pushed a commit to cojenco/python-storage that referenced this pull requestOct 13, 2021
…sion via get_distribution (googleapis#288)Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull requestOct 13, 2021
…sion via get_distribution (googleapis#288)Co-authored-by: Tres Seaver <tseaver@palladion.com>
@release-pleaserelease-pleasebot mentioned this pull requestJan 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andrewsgandrewsgAwaiting requested review from andrewsg

2 more reviewers

@tseavertseavertseaver approved these changes

@frankynfrankynfrankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crwilcox@tseaver@frankyn

[8]ページ先頭

©2009-2025 Movatter.jp