Commit0e5b718

authored

fix(perf): improve performance unmarshalling entities from protobuf2 (#175)

Uses direct access of pb2 object when iterating over Entity.properties. This reduces the time required to hydrate query results by 50%

1 parent57b0fe6 commit0e5b718Copy full SHA for 0e5b718

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def entity_from_protobuf(pb):`
`138`	`138`	`entity_meanings= {}`
`139`	`139`	`exclude_from_indexes= []`
`140`	`140`
`141`		`-forprop_name,value_pbin_property_tuples(proto_pb):`
	`141`	`+forprop_name,value_pbin_property_tuples(proto_pb._pb):`
`142`	`142`	`value=_get_value_from_value_pb(value_pb)`
`143`	`143`	`entity_props[prop_name]=value`
`144`	`144`
`@@ -154,7 +154,7 @@ def entity_from_protobuf(pb):`
`154`	`154`	`ifis_listandlen(value)>0:`
`155`	`155`	`exclude_values=set(`
`156`	`156`	`value_pb.exclude_from_indexes`
`157`		`-forvalue_pbinvalue_pb._pb.array_value.values`
	`157`	`+forvalue_pbinvalue_pb.array_value.values`
`158`	`158`	`)`
`159`	`159`	`iflen(exclude_values)!=1:`
`160`	`160`	`raiseValueError(`

Comments

(0)