Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(DBAPI): keep cursor hot when statement is a script#386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@mistercrunch
Copy link
Contributor

@mistercrunchmistercrunch commentedNov 12, 2020•
edited
Loading

all the details here:#377

I guess technically a script isn't DML:trollface:

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelNov 12, 2020
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 12, 2020
@tswast
Copy link
Contributor

Makes sense to me.

Actually, we can probably consider removing theis_dml logic altogether now that we moved togetQueryResults instead oftabledata.list (#375). The destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries. Before we do that, I'll want to double-check that we have a system test for this case. (I think a DDL to CREATE VIEW would be a good choice for that)

@mistercrunch
Copy link
ContributorAuthor

Superseded by#387

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mistercrunch@tswast
[8]ページ先頭
©2009-2025 Movatter.jp