Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: remove py.typed since package fails mypy check#988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 1 commit intomainfromrevert-976-py-typed
Sep 27, 2021

Conversation

@tswast
Copy link
Contributor

@tswasttswast requested a review froma teamSeptember 27, 2021 18:39
@tswasttswast requested a review froma team as acode ownerSeptember 27, 2021 18:39
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelSep 27, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 27, 2021
@tswasttswast mentioned this pull requestSep 27, 2021
@tswasttswast added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelSep 27, 2021
@tswast
Copy link
ContributorAuthor

Will check the library withmypy before reverting.

@tswasttswast removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelSep 27, 2021
@tswasttswast merged commit39030f2 intomainSep 27, 2021
@tswasttswast deleted the revert-976-py-typed branchSeptember 27, 2021 19:01
gcf-merge-on-greenbot pushed a commit that referenced this pull requestSep 27, 2021
@plamut
Copy link
Contributor

Do we know what exactly caused that error? Is it an issue with some of our annotations, or doesmypy behave differently frompytype?

It would be good to fix this while still retainingpy.typed, although removing it as a short term fix to unblock maintainers of other is fine.

thinkjrs reacted with thumbs up emoji

abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull requestApr 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dandhleedandhleedandhlee approved these changes

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@plamut@dandhlee

[8]ページ先頭

©2009-2025 Movatter.jp