Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for Parquet options#679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 4 commits intogoogleapis:masterfromplamut:iss-661
Jun 2, 2021

Conversation

@plamut
Copy link
Contributor

Closes#661.

For load jobs and external tables config.

PR checklist:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

simonvanderveldt reacted with thumbs up emoji
For load jobs and external tables config.
@plamutplamut requested review froma team andshollymanMay 25, 2021 14:36
@plamutplamut requested a review froma team as acode ownerMay 25, 2021 14:36
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelMay 25, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelMay 25, 2021
@google-cla
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

@google-clagoogle-clabot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsMay 25, 2021
@plamut
Copy link
ContributorAuthor

We still need to exposeParquetOptions in thegoogle.cloud.bigquery namespace to be consistent withenums, etc.

@plamutplamut added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelMay 25, 2021
@tseaver
Copy link
Contributor

@googlebot I fixed it.

@google-cla
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

1 similar comment
@google-cla
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

@plamutplamut removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelMay 26, 2021
@plamut
Copy link
ContributorAuthor

Exposed the config object ingoogle.cloud.bigquery namespace and also made sure thatparquet_options works well with theoptions attribute.

@simonvanderveldt
Copy link

simonvanderveldt commentedJun 1, 2021
edited
Loading

@plamut My team is currently a bit blocked because this functionality is missing from the BigQuery Python library. Is there anything we can do to help this get merged and released? Maybe some testing?

@plamut
Copy link
ContributorAuthor

@simonvanderveldt Thanks for bumping this, it appears that it's incorrectly blocked by the CLA bot (and still needs one approval).

@shollyman Can you please convince the bot to change its mind? :) And add a review, if possible?

Is there anything we can do to help this get merged and released? Maybe some testing?

If you want, you can test the BigQuery client with this PR branch, but primarily someone from Google with sufficient permissions needs to unblock the PR first.

@simonvanderveldt
Copy link

simonvanderveldt commentedJun 1, 2021
edited
Loading

If you want, you can test the BigQuery client with this PR branch, but primarily someone from Google with sufficient permissions needs to unblock the PR first.

Just tested it, working as expected :) We only need the list inference and using the library from this PR gives the same results as when usingbq load --parquet_enable_list_inference.

plamut reacted with thumbs up emoji

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️Googlers:Go here for more info.

@stephaniewang526
Copy link
Contributor

Looks like we're missing CLA signing fromtseaver@palladion.com

@plamut
Copy link
ContributorAuthor

But Tres is a well-known contributor? Or is it because a different email address was used?

@busunkim96
Copy link
Contributor

@plamut I looks like there is no CLA fortseaver@palladion.com.@tseaver's CLA liststres.seaver@gmail.com.

I think if you edit theCo-authored-by: Tres Seaver <tseaver@palladion.com> in the commit body the CLA bot will be appeased. Please holler if that doesn't work.

@google-cla
Copy link

CLAs look good, thanks!

ℹ️Googlers:Go here for more info.

@google-clagoogle-clabot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsJun 2, 2021
@plamut
Copy link
ContributorAuthor

That trick with editing the commit message worked, great! Since we also have an approval now, I'll merge and release this today.

@plamutplamut added the automergeMerge the pull request once unit tests and other checks pass. labelJun 2, 2021
@plamut
Copy link
ContributorAuthor

@busunkim96 As for the CLA bot, isn't this a bit fragile? Theoretically one could take another person's work posted as a suggestion, edit out the line in the commit message linking to that person, and then merge a non-CLA code into the project?

We can discuss this offline.

@plamutplamut merged commitd792ce0 intogoogleapis:masterJun 2, 2021
@gcf-merge-on-greengcf-merge-on-greenbot removed the automergeMerge the pull request once unit tests and other checks pass. labelJun 2, 2021
@plamutplamut deleted the iss-661 branchJune 2, 2021 07:17
@plamut
Copy link
ContributorAuthor

@simonvanderveldt The changes have just been released, happy coding!

@simonvanderveldt
Copy link

@plamut Awesome! Thanks a lot for the quick merge and release!

@tseaver
Copy link
Contributor

@busunkim96 literallyall of my commits to Google's repositories over the last seven years have been signed with thetseaver@palladion.com email address. The CLAbot seems flaky / fragile for commits which are merges of through-the-web suggestions.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanAwaiting requested review from shollyman

3 more reviewers

@simonvanderveldtsimonvanderveldtsimonvanderveldt left review comments

@tseavertseavertseaver left review comments

@stephaniewang526stephaniewang526stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for ParquetOptions for load/external tables

6 participants

@plamut@tseaver@simonvanderveldt@googlebot@stephaniewang526@busunkim96

[8]ページ先頭

©2009-2025 Movatter.jp