- Notifications
You must be signed in to change notification settings - Fork321
feat: add support for Parquet options#679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
For load jobs and external tables config.
Uh oh!
There was an error while loading.Please reload this page.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️Googlers:Go here for more info. |
plamut commentedMay 25, 2021
We still need to expose |
tseaver commentedMay 25, 2021
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️Googlers:Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️Googlers:Go here for more info. |
plamut commentedMay 26, 2021
Exposed the config object in |
simonvanderveldt commentedJun 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@plamut My team is currently a bit blocked because this functionality is missing from the BigQuery Python library. Is there anything we can do to help this get merged and released? Maybe some testing? |
Uh oh!
There was an error while loading.Please reload this page.
plamut commentedJun 1, 2021
@simonvanderveldt Thanks for bumping this, it appears that it's incorrectly blocked by the CLA bot (and still needs one approval). @shollyman Can you please convince the bot to change its mind? :) And add a review, if possible?
If you want, you can test the BigQuery client with this PR branch, but primarily someone from Google with sufficient permissions needs to unblock the PR first. |
simonvanderveldt commentedJun 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just tested it, working as expected :) We only need the list inference and using the library from this PR gives the same results as when using |
googlebot commentedJun 1, 2021
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️Googlers:Go here for more info. |
stephaniewang526 commentedJun 1, 2021
Looks like we're missing CLA signing from |
plamut commentedJun 1, 2021
But Tres is a well-known contributor? Or is it because a different email address was used? |
busunkim96 commentedJun 1, 2021
CLAs look good, thanks! ℹ️Googlers:Go here for more info. |
plamut commentedJun 2, 2021
That trick with editing the commit message worked, great! Since we also have an approval now, I'll merge and release this today. |
plamut commentedJun 2, 2021
@busunkim96 As for the CLA bot, isn't this a bit fragile? Theoretically one could take another person's work posted as a suggestion, edit out the line in the commit message linking to that person, and then merge a non-CLA code into the project? We can discuss this offline. |
plamut commentedJun 2, 2021
@simonvanderveldt The changes have just been released, happy coding! |
simonvanderveldt commentedJun 2, 2021
@plamut Awesome! Thanks a lot for the quick merge and release! |
tseaver commentedJun 7, 2021
@busunkim96 literallyall of my commits to Google's repositories over the last seven years have been signed with the |
Closes#661.
For load jobs and external tables config.
PR checklist: