Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(bigquery): fix repr of model reference#66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 2 commits intogoogleapis:masterfromMaxxleLLC:bigquery_issue_64
Mar 26, 2020

Conversation

@HemangChothani
Copy link
Contributor

Fixes#65

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelMar 24, 2020
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for catching that. 👍

@HemangChothani
Copy link
ContributorAuthor

The failed test has nothing to do with the changes here.

@plamut
Copy link
Contributor

Indeed, and I will temporarily disable it (as per recent discussion) until that issue gets fixed.

@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelMar 26, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelMar 26, 2020
@plamut
Copy link
Contributor

@HemangChothani Please just update the branch so that we can merge this, thanks!

@plamutplamut merged commit26c6204 intogoogleapis:masterMar 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanAwaiting requested review from shollyman

1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigquery: Model reference repr seems wrong for model_id

4 participants

@HemangChothani@plamut@googlebot@yoshi-kokoro
[8]ページ先頭
©2009-2025 Movatter.jp