Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix: Add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC#638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 5 commits intomasterfromriversnake-626
Apr 29, 2021

Conversation

@jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#626 🦕

Jim Fulton added5 commitsApril 28, 2021 13:28
To convey to the observant that these are aliases, even though they could be used (more or less) directly.
This is mainly as a backstop -- DECIMAL requests should be converted to NUMERIC.
@jimfultonjimfulton requested a review froma teamApril 29, 2021 14:58
@jimfultonjimfulton requested a review froma team as acode ownerApril 29, 2021 14:58
@jimfultonjimfulton requested review fromstephaniewang526 and removed request fora teamApril 29, 2021 14:58
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelApr 29, 2021
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelApr 29, 2021
@jimfultonjimfulton added kokoro:force-runAdd this label to force Kokoro to re-run the tests. kokoro:runAdd this label to force Kokoro to re-run the tests. and removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsApr 29, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsApr 29, 2021
@jimfultonjimfulton added the release blockingRequired feature/issue must be fixed prior to next release. labelApr 29, 2021
@tswasttswast merged commitaa59023 intomasterApr 29, 2021
@tswasttswast deleted the riversnake-626 branchApril 29, 2021 16:35
gcf-merge-on-greenbot pushed a commit that referenced this pull requestApr 29, 2021
🤖 I have created a release \*beep\* \*boop\*---## [2.15.0](https://www.github.com/googleapis/python-bigquery/compare/v2.14.0...v2.15.0) (2021-04-29)### Features* Extended DB API parameter syntax to optionally provide parameter types ([#626](https://www.github.com/googleapis/python-bigquery/issues/626)) ([8bcf397](https://www.github.com/googleapis/python-bigquery/commit/8bcf397fbe2527e06317741875a059b109cfcd9c))### Bug Fixes* add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC ([#638](https://www.github.com/googleapis/python-bigquery/issues/638)) ([aa59023](https://www.github.com/googleapis/python-bigquery/commit/aa59023317b1c63720fb717b3544f755652da58d))* The DB API Binary function accepts bytes data ([#630](https://www.github.com/googleapis/python-bigquery/issues/630)) ([4396e70](https://www.github.com/googleapis/python-bigquery/commit/4396e70771af6889d3242c37c5ff2e80241023a2))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@stephaniewang526stephaniewang526Awaiting requested review from stephaniewang526

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.release blockingRequired feature/issue must be fixed prior to next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimfulton@tswast@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp