Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: don't try to close closed DB API cursors#498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@betodealmeida
Copy link
Contributor

@betodealmeidabetodealmeida commentedJan 28, 2021
edited by plamut
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#497 🦕

@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelJan 28, 2021
@google-cla
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝Please visithttps://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with@googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️Googlers:Go here for more info.

@google-clagoogle-clabot added the cla: noThis human has *not* signed the Contributor License Agreement. labelJan 28, 2021
@betodealmeida
Copy link
ContributorAuthor

@googlebot I signed it!

@google-clagoogle-clabot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsJan 28, 2021
@betodealmeidabetodealmeida marked this pull request as ready for reviewJanuary 28, 2021 22:37
@betodealmeidabetodealmeida requested review froma team andsteffnay and removed request fora teamJanuary 28, 2021 22:37
@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 29, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 29, 2021
@plamutplamut changed the titlefix: don't try to close closed cursorsfix: don't try to close closed DB API cursorsJan 29, 2021
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thank you!

@plamutplamut merged commitbf44e7b intogoogleapis:masterJan 29, 2021
gcf-merge-on-greenbot pushed a commit that referenced this pull requestFeb 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@steffnaysteffnayAwaiting requested review from steffnay

1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Closing a connection tries to close already closed cursors

3 participants

@betodealmeida@plamut@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp