- Notifications
You must be signed in to change notification settings - Fork321
fix: add minimum timeout to getQueryResults API requests#444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Since successful responses can still take a long time to download, havea minimum timeout which should accomodate 99.9%+ of responses.I figure it's more important that *any* timeout is set if desired thanit is that the specific timeout is used. This is especially true incases where a short timeout is requested for the purposes of a progressbar. Making forward progress is more important than the progress barupdate frequency.
shollyman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
one minor question about documenting behavior.
| } | ||
| iftimeoutisnotNone: | ||
| timeout=max(timeout,_MIN_GET_QUERY_RESULTS_TIMEOUT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we document this in the methods? e.g. timeout less than the _MIN_GET_QUERY_RESULTS_TIMEOUT are ignored?
…rm/python-docs-samples#444)Put them in their own directory, since they duplicate the content fromthe existing samples that use the generated libraries.
Since successful responses can still take a long time to download, have
a minimum timeout which should accomodate 99.9%+ of responses.
I figure it's more important thatany timeout is set if desired than
it is that the specific timeout is used. This is especially true in
cases where a short timeout is requested for the purposes of a progress
bar. Making forward progress is more important than the progress bar
update frequency.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#438 🦕