Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: fix Shapely import in GEOGRAPHY sample#431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 1 commit intogoogleapis:masterfromtswast:b171804665-geography
Dec 9, 2020

Conversation

@tswast
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswasttswast requested a review froma team as acode ownerDecember 9, 2020 22:36
@tswasttswast requested review frombusunkim96 and removed request fora teamDecember 9, 2020 22:36
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelDec 9, 2020
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelDec 9, 2020
@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelDec 9, 2020
Copy link
Contributor

@shollymanshollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM assuming tests ok

@tswasttswast merged commit96a1c5b intogoogleapis:masterDec 9, 2020
@tswasttswast deleted the b171804665-geography branchDecember 9, 2020 22:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes

+1 more reviewer

@busunkim96busunkim96busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@shollyman@busunkim96
[8]ページ先頭
©2009-2025 Movatter.jp