Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add GEOGRAPHY data type code samples#428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 2 commits intogoogleapis:masterfromtswast:b171804665-geography
Dec 9, 2020

Conversation

@tswast
Copy link
Contributor

These are added to a separate directory in order to isolate the GeoJSON
and WKT dependencies from the other code samples.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal 171804665

These are added to a separate directory in order to isolate the GeoJSONand WKT dependencies from the other code samples.
@tswasttswast requested a review froma team as acode ownerDecember 9, 2020 19:50
@tswasttswast requested review fromtmatsuo and removed request fora teamDecember 9, 2020 19:50
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelDec 9, 2020
@snippet-bot
Copy link

snippet-botbot commentedDec 9, 2020
edited
Loading

Here is the summary of changes.

You added 4 region tags.

This comment is generated bysnippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, addsnippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelDec 9, 2020
@product-auto-labelproduct-auto-labelbot added the samplesIssues that are directly related to samples. labelDec 9, 2020
@tswasttswast requested a review froma teamDecember 9, 2020 20:10
SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not really associated with this sample, but the system test flaked, so I figured I'd swap out this query with one from go/bq-long-queries

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good.

Copy link
Contributor

@shollymanshollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was today years old when I found out that streaming inserts will accept either WKT or geojson as the field contents.

SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good.

importnox


# WARNING - WARNING - WARNING - WARNING - WARNING
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This file is generated?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tswasttswast merged commitdbc68b3 intogoogleapis:masterDec 9, 2020
@tswasttswast deleted the b171804665-geography branchDecember 9, 2020 22:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shollymanshollymanshollyman approved these changes

@tmatsuotmatsuoAwaiting requested review from tmatsuo

@steffnaysteffnayAwaiting requested review from steffnay

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@shollyman

[8]ページ先頭

©2009-2025 Movatter.jp