Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for unrecognized model types#401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
steffnay merged 3 commits intogoogleapis:masterfromsteffnay:model-const
Nov 30, 2020

Conversation

@steffnay
Copy link
Contributor

@steffnaysteffnay commentedNov 25, 2020
edited
Loading

If fails to parse model type enum, sets to MODEL_TYPE_UNSPECIFIED.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#334 🦕

@steffnaysteffnay requested review froma team andpmakaniNovember 25, 2020 13:15
@product-auto-labelproduct-auto-labelbot added the api: bigqueryIssues related to the googleapis/python-bigquery API. labelNov 25, 2020
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 25, 2020
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wonderful!

@steffnaysteffnay merged commit168f035 intogoogleapis:masterNov 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@pmakanipmakaniAwaiting requested review from pmakani

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Model constructor robust against new model types

2 participants

@steffnay@tswast

[8]ページ先頭

©2009-2025 Movatter.jp