- Notifications
You must be signed in to change notification settings - Fork321
perf: usegetQueryResults from DB-API#375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I suspect `list_rows` (`tabledata.list`) was being called directlydue to no `page_size` parameter on `QueryJob.result` at the time.
steffnay approved these changesNov 10, 2020
This was referencedNov 12, 2020
gcf-merge-on-greenbot pushed a commit that referenced this pull requestNov 12, 2020
The `is_dml` logic is not needed now that we moved to `getQueryResults` instead of `tabledata.list` (#375).Previously, the destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [ ] Ensure the tests and linter pass- [ ] Code coverage does not decrease (if any source code was changed)- [ ] Appropriate docs were updated (if necessary)Towards#377 🦕
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API. cla: yesThis human has signed the Contributor License Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect
list_rows(tabledata.list) was being called directlydue to no
page_sizeparameter onQueryJob.resultat the time.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards#362 🦕