Commitd93986e

authored

feat: addExternalConfig.connection_id property to connect to external sources (#560)

* feat: add `ExternalConfig.connection_id` property to connect to external sources* add tests* fix unit tests

1 parent97ee6ec commitd93986eCopy full SHA for d93986e

File tree

+25

-0

lines changed

+25

-0

lines changed

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -760,6 +760,23 @@ def schema(self):`
`760`	`760`	`prop=self._properties.get("schema", {})`
`761`	`761`	`return [SchemaField.from_api_repr(field)forfieldinprop.get("fields", [])]`
`762`	`762`
	`763`	`+@property`
	`764`	`+defconnection_id(self):`
	`765`	`+"""Optional[str]: [Experimental] ID of a BigQuery Connection API`
	`766`	`+ resource.`
	`767`	`+`
	`768`	`+ .. WARNING::`
	`769`	`+`
	`770`	`+ This feature is experimental. Pre-GA features may have limited`
	`771`	`+ support, and changes to pre-GA features may not be compatible with`
	`772`	`+ other pre-GA versions.`
	`773`	`+ """`
	`774`	`+returnself._properties.get("connectionId")`
	`775`	`+`
	`776`	`+@connection_id.setter`
	`777`	`+defconnection_id(self,value):`
	`778`	`+self._properties["connectionId"]=value`
	`779`	`+`
`763`	`780`	`@schema.setter`
`764`	`781`	`defschema(self,value):`
`765`	`782`	`prop=value`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ def test_to_api_repr_base(self):`
`74`	`74`	`ec.autodetect=True`
`75`	`75`	`ec.ignore_unknown_values=False`
`76`	`76`	`ec.compression="compression"`
	`77`	`+ec.connection_id="path/to/connection"`
`77`	`78`	`ec.schema= [schema.SchemaField("full_name","STRING",mode="REQUIRED")]`
`78`	`79`
`79`	`80`	`exp_schema= {`
`@@ -87,10 +88,17 @@ def test_to_api_repr_base(self):`
`87`	`88`	`"autodetect":True,`
`88`	`89`	`"ignoreUnknownValues":False,`
`89`	`90`	`"compression":"compression",`
	`91`	`+"connectionId":"path/to/connection",`
`90`	`92`	`"schema":exp_schema,`
`91`	`93`	`}`
`92`	`94`	`self.assertEqual(got_resource,exp_resource)`
`93`	`95`
	`96`	`+deftest_connection_id(self):`
	`97`	`+ec=external_config.ExternalConfig("")`
	`98`	`+self.assertIsNone(ec.connection_id)`
	`99`	`+ec.connection_id="path/to/connection"`
	`100`	`+self.assertEqual(ec.connection_id,"path/to/connection")`
	`101`	`+`
`94`	`102`	`deftest_schema_None(self):`
`95`	`103`	`ec=external_config.ExternalConfig("")`
`96`	`104`	`ec.schema=None`

Comments

(0)