Commit5dd1a5e

authored

fix(dbapi): avoid running % format with no query parameters (#348)

* fix: aviod running %format when no query params* fix: nit* fix: change in unit test

1 parente51fd45 commit5dd1a5eCopy full SHA for 5dd1a5e

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ def _format_operation(operation, parameters=None):`
`441`	`441`	`if a parameter used in the operation is not found in the`
`442`	`442`	``parameters`` argument.
`443`	`443`	`"""`
`444`		`-ifparametersisNone:`
	`444`	`+ifparametersisNoneorlen(parameters)==0:`
`445`	`445`	`returnoperation`
`446`	`446`
`447`	`447`	`ifisinstance(parameters,collections_abc.Mapping):`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -601,3 +601,9 @@ def test__format_operation_w_too_short_sequence(self):`
`601`	`601`	`"SELECT %s, %s;",`
`602`	`602`	`("hello",),`
`603`	`603`	`)`
	`604`	`+`
	`605`	`+deftest__format_operation_w_empty_dict(self):`
	`606`	`+fromgoogle.cloud.bigquery.dbapiimportcursor`
	`607`	`+`
	`608`	`+formatted_operation=cursor._format_operation("SELECT '%f'", {})`
	`609`	`+self.assertEqual(formatted_operation,"SELECT '%f'")`

Comments

(0)