- Notifications
You must be signed in to change notification settings - Fork95
fix: use version.py instead of pkg_resources.get_distribution#80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
andrewsg approved these changesOct 5, 2020
Contributor
andrewsg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks Chris! Do we need to change release-please or any other tooling?
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
crwilcox commentedOct 5, 2020
@andrewsg already underway and part of next release-please release. |
gcf-merge-on-greenbot pushed a commit to googleapis/google-auth-library-python that referenced this pull requestMar 16, 2021
Move the version from `setup.py` to `google/auth/version.py`. Same asgoogleapis/python-api-core#80. (seegoogleapis/python-api-core#27 for motivation). This is option 3 inhttps://packaging.python.org/guides/single-sourcing-package-version/.This unblocks a version check I'd like to add ingoogleapis/python-api-core#134.Usage:```py>>> import google.auth>>> google.auth.__version__'1.25.0'```
This was referencedMay 30, 2025
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull requestNov 26, 2025
Move the version from `setup.py` to `google/auth/version.py`. Same asgoogleapis/python-api-core#80. (seegoogleapis/python-api-core#27 for motivation). This is option 3 inhttps://packaging.python.org/guides/single-sourcing-package-version/.This unblocks a version check I'd like to add ingoogleapis/python-api-core#134.Usage:```py>>> import google.auth>>> google.auth.__version__'1.25.0'```
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Related:#27