NotificationsYou must be signed in to change notification settings
Fork95
Star144

feat: AsyncIO Integration [Part 3]#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

busunkim96 merged 1 commit intogoogleapis:masterfromlidizheng:aio-part-3

Jun 4, 2020

Merged

feat: AsyncIO Integration [Part 3]#29

busunkim96 merged 1 commit intogoogleapis:masterfromlidizheng:aio-part-3

Jun 4, 2020

Conversation

Copy link

Contributor

lidizheng commentedMay 18, 2020

Children PR of#26 and#28.

This PR includes AsyncIO version of:

LRO client
gRPC wrappers & helpers

Related#23

googlebot added the cla: yesThis human has signed the Contributor License Agreement. label

May 18, 2020

lidizheng marked this pull request as ready for review

May 18, 2020 22:34

busunkim96 requested review frombusunkim96 andsoftware-dov

May 27, 2020 00:28

busunkim96 reviewed

May 27, 2020

View reviewed changes

google/api_core/grpc_helpers_async.pyShow resolvedHide resolved

google/api_core/grpc_helpers_async.py OutdatedShow resolvedHide resolved

google/api_core/grpc_helpers_async.py

Comment on lines +237 to +270

		classFakeUnaryUnaryCall(_WrappedUnaryUnaryCall):
		"""Fake implementation for unary-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse


		classFakeStreamUnaryCall(_WrappedStreamUnaryCall):
		"""Fake implementation for stream-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse

		asyncdefwait_for_connection(self):
		pass

Copy link

Contributor

busunkim96May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are these intended for use by tests only? I'd prefer they be namedMock... instead ofFake... but don't feel too strongly about it.

Copy link

ContributorAuthor

lidizhengMay 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I consideredMock... naming, but they are not magic mock objects. It might misdirect users' expectation of its behavior. I'm happy to change if you have better naming.

Copy link

Contributor

busunkim96May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's leave it as is then.@software-dov do you have any thoughts here?

Copy link

Contributor

software-dovJun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1 to not mock naming, although I'm a little confused as to why they don't live in the unit test file.

Copy link

Contributor

busunkim96Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think leaving them here makes it easier for dependent libraries to use it in their own tests.

(HttpMock in the apiary library for instance)

Copy link

Contributor

software-dovJun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the 'correct' think to do then would be to have a testlib. I am in general not a fan of mixing test code and production code, but it's not a hill I'm willing to die on.

lidizheng force-pushed theaio-part-3 branch from421ef12 to11f63d6Compare

May 27, 2020 17:28

lidizheng commented

May 27, 2020

View reviewed changes

Copy link

ContributorAuthor

lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@busunkim96 Thank you for the suggestions. PTALA.

google/api_core/grpc_helpers_async.py OutdatedShow resolvedHide resolved

google/api_core/grpc_helpers_async.py

Comment on lines +237 to +270

		classFakeUnaryUnaryCall(_WrappedUnaryUnaryCall):
		"""Fake implementation for unary-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse


		classFakeStreamUnaryCall(_WrappedStreamUnaryCall):
		"""Fake implementation for stream-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse

		asyncdefwait_for_connection(self):
		pass

Copy link

ContributorAuthor

lidizhengMay 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I consideredMock... naming, but they are not magic mock objects. It might misdirect users' expectation of its behavior. I'm happy to change if you have better naming.

busunkim96 mentioned this pull request

May 27, 2020

chore: release 1.18.0#33

Merged

lidizheng force-pushed theaio-part-3 branch from11f63d6 to9a8906eCompare

June 2, 2020 22:09

software-dov reviewed

Jun 3, 2020

View reviewed changes

google/api_core/gapic_v1/method_async.py Outdated

Comment on lines 42 to 45

		ifclient_infoisnotNone:
		user_agent_metadata= [client_info.to_grpc_metadata()]
		else:
		user_agent_metadata=None

Copy link

Contributor

software-dovJun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Style nit: what about

metadata= [client_info.to_grpc_metadata()]ifclient_infoisnotNoneelseNone

Copy link

ContributorAuthor

lidizhengJun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good idea. Updated to the suggested style.

google/api_core/grpc_helpers_async.py

Comment on lines +237 to +270

		classFakeUnaryUnaryCall(_WrappedUnaryUnaryCall):
		"""Fake implementation for unary-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse


		classFakeStreamUnaryCall(_WrappedStreamUnaryCall):
		"""Fake implementation for stream-unary RPCs.

		It is a dummy object for response message. Supply the intended response
		upon the initialization, and the coroutine will return the exact response
		message.
		"""

		def__init__(self,response=object()):
		self.response=response
		self._future=asyncio.get_event_loop().create_future()
		self._future.set_result(self.response)

		def__await__(self):
		response=yieldfromself._future.__await__()
		returnresponse

		asyncdefwait_for_connection(self):
		pass

Copy link

Contributor

software-dovJun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1 to not mock naming, although I'm a little confused as to why they don't live in the unit test file.

software-dov mentioned this pull request

Jun 3, 2020

asyncio supportgoogleapis/google-cloud-python#3103

Closed

kamyar mentioned this pull request

Jun 3, 2020

FR: Async requestsfirebase/firebase-admin-python#104

Open

lidizheng force-pushed theaio-part-3 branch from9a8906e tocc8dc51Compare

June 3, 2020 18:53

Copy link

ContributorAuthor

lidizheng commentedJun 3, 2020

@software-dov PTALA.

Copy link

Contributor

busunkim96 commentedJun 4, 2020

@lidizheng It looks like the unit tests need to be tweaked:

func = <function _wrap_unary_errors.<locals>.error_remapped_callable at 0x7fb165893790>default_retry = <google.api_core.retry_async.AsyncRetry object at 0x7fb166304160>default_timeout = <google.api_core.timeout.ExponentialTimeout object at 0x7fb1663046d0>client_info = <google.api_core.gapic_v1.client_info.ClientInfo object at 0x7fb1664eeeb0>    def wrap_method(            func,            default_retry=None,            default_timeout=None,            client_info=client_info.DEFAULT_CLIENT_INFO,    ):        """Wrap an async RPC method with common behavior.        Returns:            Callable: A new callable that takes optional ``retry`` and ``timeout``                arguments and applies the common error mapping, retry, timeout,                and metadata behavior to the low-level RPC method.        """        func = grpc_helpers_async.wrap_errors(func)        metadata = [client_info.to_grpc_metadata()] if client_info is not None else None        return general_helpers.wraps(func)(_GapicCallable(>           func, default_retry, default_timeout, metadata=user_agent_metadata))E       NameError: name 'user_agent_metadata' is not defined

lidizheng force-pushed theaio-part-3 branch fromcc8dc51 to7778770Compare

June 4, 2020 17:07

busunkim96 approved these changes

Jun 4, 2020

View reviewed changes

software-dov approved these changes

Jun 4, 2020

View reviewed changes

Copy link

Contributor

software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Just one minor optional tweak and a vote from my end that the test classes be moved into a standalone test library.

google/api_core/operations_v1/__init__.py OutdatedShow resolvedHide resolved

feat: Third batch of AsyncIO integration

7f319ab

* LRO client* gRPC wrappers & helpers* With unit tests & docs

lidizheng force-pushed theaio-part-3 branch from7778770 to7f319abCompare

June 4, 2020 17:37

busunkim96 merged commit7d8d580 intogoogleapis:master

Jun 4, 2020

gcf-merge-on-greenbot pushed a commit that referenced this pull request

Jun 4, 2020

chore: release 1.18.0 (#33)

33ab7fa

🤖 I have created a release \*beep\* \*boop\* ---## [1.18.0](https://www.github.com/googleapis/python-api-core/compare/v1.17.0...v1.18.0) (2020-06-04)### Features* [CBT-6 helper] Exposing Retry._deadline as a property ([#20](https://www.github.com/googleapis/python-api-core/issues/20)) ([7be1e59](https://www.github.com/googleapis/python-api-core/commit/7be1e59e9d75c112f346d2b76dce3dd60e3584a1))* add client_encryped_cert_source to ClientOptions ([#31](https://www.github.com/googleapis/python-api-core/issues/31)) ([e4eaec0](https://www.github.com/googleapis/python-api-core/commit/e4eaec0ff255114138d3715280f86d34d861a6fa))* AsyncIO Integration [Part 2] ([#28](https://www.github.com/googleapis/python-api-core/issues/28)) ([dd9b2f3](https://www.github.com/googleapis/python-api-core/commit/dd9b2f38a70e85952cc05552ec8070cdf29ddbb4)), closes [#23](https://www.github.com/googleapis/python-api-core/issues/23)* First batch of AIO integration ([#26](https://www.github.com/googleapis/python-api-core/issues/26)) ([a82f289](https://www.github.com/googleapis/python-api-core/commit/a82f2892b8f219b82e120e6ed9f4070869c28be7))* third batch of AsyncIO integration ([#29](https://www.github.com/googleapis/python-api-core/issues/29)) ([7d8d580](https://www.github.com/googleapis/python-api-core/commit/7d8d58075a92e93662747d36a2d55b5e9f0943e1))---This PR was generated with [Release Please](https://github.com/googleapis/release-please).

busunkim96 mentioned this pull request

Jun 17, 2020

WIP: AsyncIO integration#22

Closed

4 tasks

This was referencedMay 30, 2025

chore(main): release 2.0.0#822

Closed

chore(main): release 2.0.0#823

Closed

Labels

cla: yes

This human has signed the Contributor License Agreement.

Movatterモバイル変換

feat: AsyncIO Integration [Part 3]#29

feat: AsyncIO Integration [Part 3]#29

Uh oh!

Conversation

lidizheng commentedMay 18, 2020

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidizheng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidizheng commentedJun 3, 2020

Uh oh!

busunkim96 commentedJun 4, 2020

Uh oh!

software-dov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants