- Notifications
You must be signed in to change notification settings - Fork95
feat: HTTPIterator now accepts a page_size parameter to control page …#197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tests/unit/test_page_iterator.py Outdated
| deftest_page_size_items(self,page_size,max_results,pages): | ||
| path="/foo" | ||
| NITEMS=10 | ||
| page_size=3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like this is getting set twice, once via "parametrize" and once here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed. Thanks!
(This was left over from before this was parametrized.)
jimfulton commentedMay 28, 2021
@chrisrossi are you ready to approve? :) |
chrisrossi commentedJun 2, 2021
Sorry, I missed this message. Yes, I was, but I don't think my approval would have made it mergeable. |
…size
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#194 🦕