- Notifications
You must be signed in to change notification settings - Fork95
fix: save empty IAM policy bindings#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| assertlen(policy)==0 | ||
| assertdict(policy)== {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Accessingpolicy.owners,policy.editors results in__getitem__ being called, which adds empty entries to the dictionary. I moved these empty dict asserts up as a result.
An alternative is to keep them in their previous location and check that the three roles with empty bindings were added
Uh oh!
There was an error while loading.Please reload this page.
Fixes#154
__getitem__currently returns an emptyset()for items not in the bindings. If someone adds to the set returned by__getitem__the changes will not be reflected on the actual policy object.