Commit8f8ee78

authored

fix: only add quota project id if supported (#75)

1 parent6229317 commit8f8ee78Copy full SHA for 8f8ee78

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ def _create_composite_credentials(`
`216`	`216`	`else:`
`217`	`217`	`credentials,_=google.auth.default(scopes=scopes)`
`218`	`218`
`219`		`-ifquota_project_id:`
	`219`	`+ifquota_project_idandisinstance(credentials,google.auth.credentials.CredentialsWithQuotaProject):`
`220`	`220`	`credentials=credentials.with_quota_project(quota_project_id)`
`221`	`221`
`222`	`222`	`request=google.auth.transport.requests.Request()`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`dependencies= [`
`32`	`32`	`"googleapis-common-protos >= 1.6.0, < 2.0dev",`
`33`	`33`	`"protobuf >= 3.12.0",`
`34`		`-"google-auth >= 1.19.1, < 2.0dev",`
	`34`	`+"google-auth >= 1.21.1, < 2.0dev",`
`35`	`35`	`"requests >= 2.18.0, < 3.0.0dev",`
`36`	`36`	`"setuptools >= 34.0.0",`
`37`	`37`	`"six >= 1.10.0",`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ def test_create_channel_explicit_with_quota_project(grpc_secure_channel, composi`
`369`	`369`	`target="example.com:443"`
`370`	`370`	`composite_creds=composite_creds_call.return_value`
`371`	`371`
`372`		`-credentials=mock.create_autospec(google.auth.credentials.Credentials,instance=True)`
	`372`	`+credentials=mock.create_autospec(google.auth.credentials.CredentialsWithQuotaProject,instance=True)`
`373`	`373`
`374`	`374`	`channel=grpc_helpers_async.create_channel(`
`375`	`375`	`target,credentials=credentials,quota_project_id="project-foo"`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ def test_create_channel_explicit_with_quota_project(grpc_secure_channel, composi`
`341`	`341`	`target="example.com:443"`
`342`	`342`	`composite_creds=composite_creds_call.return_value`
`343`	`343`
`344`		`-credentials=mock.create_autospec(google.auth.credentials.Credentials,instance=True)`
	`344`	`+credentials=mock.create_autospec(google.auth.credentials.CredentialsWithQuotaProject,instance=True)`
`345`	`345`
`346`	`346`	`channel=grpc_helpers.create_channel(`
`347`	`347`	`target,`

Comments

(0)