NotificationsYou must be signed in to change notification settings
Fork95
Star144

Commit6ae04a8

authored

feat: retry google.auth TransportError and requests ConnectionError (#178)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-api-core/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea- [x] Ensure the tests and linter pass- [x] Code coverage does not decrease (if any source code was changed)- [x] Appropriate docs were updated (if necessary)Fixes#176 🦕

1 parentf87bccb commit6ae04a8Copy full SHA for 6ae04a8

File tree

2 files changed

-0

lines changed

google/api_core
- retry.py
tests/unit
- test_retry.py

2 files changed

-0

lines changed

`‎google/api_core/retry.py‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,13 @@ def check_if_exists():`
`62`	`62`	`importrandom`
`63`	`63`	`importtime`
`64`	`64`
	`65`	`+importrequests.exceptions`
`65`	`66`	`importsix`
`66`	`67`
`67`	`68`	`fromgoogle.api_coreimportdatetime_helpers`
`68`	`69`	`fromgoogle.api_coreimportexceptions`
`69`	`70`	`fromgoogle.api_coreimportgeneral_helpers`
	`71`	`+fromgoogle.authimportexceptionsasauth_exceptions`
`70`	`72`
`71`	`73`	`_LOGGER=logging.getLogger(__name__)`
`72`	`74`	`_DEFAULT_INITIAL_DELAY=1.0# seconds`
`@@ -101,6 +103,8 @@ def if_exception_type_predicate(exception):`
`101`	`103`	`exceptions.InternalServerError,`
`102`	`104`	`exceptions.TooManyRequests,`
`103`	`105`	`exceptions.ServiceUnavailable,`
	`106`	`+requests.exceptions.ConnectionError,`
	`107`	`+auth_exceptions.TransportError,`
`104`	`108`	`)`
`105`	`109`	`"""A predicate that checks if an exception is a transient API error.`
`106`	`110`

`‎tests/unit/test_retry.py‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,11 @@`
`18`	`18`
`19`	`19`	`importmock`
`20`	`20`	`importpytest`
	`21`	`+importrequests.exceptions`
`21`	`22`
`22`	`23`	`fromgoogle.api_coreimportexceptions`
`23`	`24`	`fromgoogle.api_coreimportretry`
	`25`	`+fromgoogle.authimportexceptionsasauth_exceptions`
`24`	`26`
`25`	`27`
`26`	`28`	`deftest_if_exception_type():`
`@@ -42,6 +44,8 @@ def test_if_transient_error():`
`42`	`44`	`assertretry.if_transient_error(exceptions.InternalServerError(""))`
`43`	`45`	`assertretry.if_transient_error(exceptions.TooManyRequests(""))`
`44`	`46`	`assertretry.if_transient_error(exceptions.ServiceUnavailable(""))`
	`47`	`+assertretry.if_transient_error(requests.exceptions.ConnectionError(""))`
	`48`	`+assertretry.if_transient_error(auth_exceptions.TransportError(""))`
`45`	`49`	`assertnotretry.if_transient_error(exceptions.InvalidArgument(""))`
`46`	`50`
`47`	`51`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6ae04a8

File tree

2 files changed

2 files changed

`‎google/api_core/retry.py‎`

`‎tests/unit/test_retry.py‎`

0 commit comments