- Notifications
You must be signed in to change notification settings - Fork90
Comments
fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication#759
Merged
BenWhitehead merged 1 commit intogoogleapis:masterfromMar 16, 2021
BenWhitehead:fix-755
Merged
fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication#759BenWhitehead merged 1 commit intogoogleapis:masterfromBenWhitehead:fix-755
BenWhitehead merged 1 commit intogoogleapis:masterfrom
BenWhitehead:fix-755
Conversation
…nloadPublicBlobWithoutAuthenticationPort ofgoogleapis/google-cloud-go#3806Fixes#755
codecovbot commentedMar 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #759 +/- ##========================================= Coverage 64.61% 64.61% Complexity 634 634 ========================================= Files 32 32 Lines 5313 5313 Branches 519 519 ========================================= Hits 3433 3433 Misses 1718 1718 Partials 162 162 Continue to review full report at Codecov.
|
tritone approved these changesMar 16, 2021
gcf-merge-on-greenbot pushed a commit that referenced this pull requestApr 13, 2021
🤖 I have created a release \*beep\* \*boop\*---### [1.113.15](https://www.github.com/googleapis/java-storage/compare/v1.113.14...v1.113.15) (2021-04-13)### Bug Fixes* **test:** update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication ([#759](https://www.github.com/googleapis/java-storage/issues/759)) ([9a6619c](https://www.github.com/googleapis/java-storage/commit/9a6619c39a89e2c2ee8d0000d595d09ac7b7825f))* typo ([#779](https://www.github.com/googleapis/java-storage/issues/779)) ([3c3d6b4](https://www.github.com/googleapis/java-storage/commit/3c3d6b487648fde4eb956ce8912cd680a4440f8d))### Dependencies* update dependency com.google.api-client:google-api-client to v1.31.4 ([#774](https://www.github.com/googleapis/java-storage/issues/774)) ([ad9ff7b](https://www.github.com/googleapis/java-storage/commit/ad9ff7b801d0c5fb39f72c7118c319f4e45084a0))* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#771](https://www.github.com/googleapis/java-storage/issues/771)) ([5605095](https://www.github.com/googleapis/java-storage/commit/5605095ed796327879a930c12526b3c5b1409b17))* update kms.version to v0.88.1 ([#758](https://www.github.com/googleapis/java-storage/issues/758)) ([3e57ea9](https://www.github.com/googleapis/java-storage/commit/3e57ea9a2f5f7013e997469c5ca32be8cef2a4a4))* update kms.version to v0.88.2 ([#778](https://www.github.com/googleapis/java-storage/issues/778)) ([6edfc4c](https://www.github.com/googleapis/java-storage/commit/6edfc4ced2bdae9878ecdbc5ef636ac39bdb5881))* update truth ([#767](https://www.github.com/googleapis/java-storage/issues/767)) ([4e5ee03](https://www.github.com/googleapis/java-storage/commit/4e5ee0398e700baf4f88224f66309e426f9532d7))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
BenWhitehead added a commit that referenced this pull requestMay 11, 2021
…nloadPublicBlobWithoutAuthentication (#759) (#817)Port ofgoogleapis/google-cloud-go#3806Fixes#755cherry-pick from9a6619c
BenWhitehead added a commit that referenced this pull requestMay 11, 2021
…nloadPublicBlobWithoutAuthentication (#759) (#818)Port ofgoogleapis/google-cloud-go#3806Fixes#755cherry-pick from9a6619c
gcf-merge-on-greenbot pushed a commit that referenced this pull requestMay 13, 2021
🤖 I have created a release \*beep\* \*boop\*---## [1.114.0](https://www.github.com/googleapis/java-storage/compare/v1.113.16...v1.114.0) (2021-05-13)### Features* Remove client side vaildation for lifecycle conditions ([#816](https://www.github.com/googleapis/java-storage/issues/816)) ([5ec84cc](https://www.github.com/googleapis/java-storage/commit/5ec84cc2935a4787dd14a207d27501878f5849d5))### Bug Fixes* **test:** update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication ([#759](https://www.github.com/googleapis/java-storage/issues/759)) ([#817](https://www.github.com/googleapis/java-storage/issues/817)) ([1a576ca](https://www.github.com/googleapis/java-storage/commit/1a576ca3945b51d7a678aa2414be91b3c6b2d55e))### Dependencies* update dependency com.google.api-client:google-api-client to v1.31.5 ([#820](https://www.github.com/googleapis/java-storage/issues/820)) ([9e1bc0b](https://www.github.com/googleapis/java-storage/commit/9e1bc0b42abdaab0b11d761ecdbb92f6116aacd2))* update dependency com.google.api.grpc:grpc-google-cloud-kms-v1 to v0.88.3 ([#797](https://www.github.com/googleapis/java-storage/issues/797)) ([747e7e4](https://www.github.com/googleapis/java-storage/commit/747e7e463c028b9cf8a406b7536b1916c1d52c01))* update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#815](https://www.github.com/googleapis/java-storage/issues/815)) ([e210de9](https://www.github.com/googleapis/java-storage/commit/e210de93452243242be7d3d719d00da723632335))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
danielduhh pushed a commit to danielduhh/java-storage that referenced this pull requestJun 9, 2021
…nloadPublicBlobWithoutAuthentication (googleapis#759)Port ofgoogleapis/google-cloud-go#3806Fixesgoogleapis#755
danielduhh added a commit that referenced this pull requestJun 10, 2021
* build: add kokoro & ci changes* add samples folder to pass ci* build: pin fmt-maven-plugin version to 2.9fmt-maven-plugin v2.10 is compiled for java 11, v2.9 is compiled for java 8port of fix fromgoogleapis/java-shared-config#90* remove samples directory & ci* add ci block* remove snippet bot config* sync ci changes* fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)Port ofgoogleapis/google-cloud-go#3806Fixes#755Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
danielduhh pushed a commit that referenced this pull requestJun 17, 2021
…nloadPublicBlobWithoutAuthentication (#759)Port ofgoogleapis/google-cloud-go#3806Fixes#755
danielduhh added a commit that referenced this pull requestJun 17, 2021
* feat: configure initial sp version* fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759)Port ofgoogleapis/google-cloud-go#3806Fixes#755* test: remove error string matching (#861)It looks like the text for this error on the backend has changed(sometimes) from "Precondition Failed" to "At least one of thepre-conditions you specified did not hold". I don't think it'sreally necessary to check the exact message in any case giventhat we do check for a code of 412, which implies a preconditionfailure. I added a check of the error Reason instead, which is morestandardized.Fixes#853Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>Co-authored-by: Chris Cotter <cjcotter@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: storageIssues related to the googleapis/java-storage API. cla: yesThis human has signed the Contributor License Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port ofgoogleapis/google-cloud-go#3806
Fixes#755