- Notifications
You must be signed in to change notification settings - Fork90
Comments
feat: add delimiter BlobListOption#102
Merged
frankyn merged 4 commits intogoogleapis:masterfromFeb 14, 2020
Merged
Conversation
codecovbot commentedJan 30, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #102 +/- ##============================================+ Coverage 63.30% 63.62% +0.32%- Complexity 528 539 +11============================================ Files 30 30 Lines 4720 4729 +9 Branches 450 426 -24 ============================================+ Hits 2988 3009 +21+ Misses 1571 1562 -9+ Partials 161 158 -3
Continue to review full report at Codecov.
|
| } | ||
| /** Returns an option to set a delimiter '/'. */ | ||
| public static BlobListOption delimiter() { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Delimiter can be user defined, generally '/' is the one used most often, but I'd like to keep this open to other delimiters.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
ContributorAuthor
athakor commentedFeb 10, 2020
@frankyn PTAL |
frankyn approved these changesFeb 14, 2020
Contributor
frankyn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#99