Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3k
[feat] add an API to get the final url after following redirect responses#1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
k3-cat wants to merge27 commits intoSagerNet:dev-nextChoose a base branch
base:dev-next
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The `process_path` rule of sing-box is inherited from Clash,the original code uses the local system's path format (e.g. `\Device\HarddiskVolume1\folder\program.exe`),but when the device has multiple disks, the HarddiskVolume serial number is not stable.This change make QueryFullProcessImageNameW output a Win32 path (such as `C:\folder\program.exe`),which will disrupt the existing `process_path` use cases in Windows.
For historical reasons, sing-box's `domain_suffix` rule matches literal prefixes instead of the same as other projects.This change modifies the behavior of `domain_suffix`: If the rule value is prefixed with `.`,the behavior is unchanged, otherwise it matches `(domain|.+\.domain)` instead.
Signed-off-by: 气息 <qdshizh@gmail.com>
3611dcd to36c095fCompare4492a53 to989034bCompare8ec5593 tob3c1110CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new Method
getFinalURL() -> stringtoexperimental/libbox.HTTPResponse, which allows the caller obtain the final URL after been redirected.Motivation
This change should bring the following benefits:
Expected influences
None
According toRef1,
net/http.Clientwill follows a redirect response (if less than 10 times) by default. From my test, all existing sing-box apps follow this default behaviour, and this change will not break this behaviour. In addition, the connection can be protected by TLS, so this change should not introduce extra security issue.