- Notifications
You must be signed in to change notification settings - Fork370
feat: Reload customer center onCustomerCenterPromotionalOfferSuccess#4917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Reload customer center onCustomerCenterPromotionalOfferSuccess#4917
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ccessful-promotional
Uh oh!
There was an error while loading.Please reload this page.
@RCGitBot please test |
RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptions/ManageSubscriptionsViewModel.swift OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptions/ManageSubscriptionsViewModel.swiftShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
@RCGitBot please test |
The failing tests seem to be failing in the release as well 🤔 |
…ccessful-promotional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! 🚀
…ccessful-promotional
d23292a intomainUh oh!
There was an error while loading.Please reload this page.
Changing label here to |
Motivation
We need to reload the customer center once a promotional offer succeeds.
Description
I am following the same pattern using PreferenceKeys, which can already be tested#4916 to keep everything consistent.
A loading indicator (for when the screen already contains data) would be ideal, but I've created a ticket to do that separately.