Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rename non-type template parameter/argument to "constant"#7587

Merged
tkoeppe merged 8 commits intocplusplus:mainfrom
cor3ntin:non_type
Feb 10, 2025
Merged

Rename non-type template parameter/argument to "constant"#7587
tkoeppe merged 8 commits intocplusplus:mainfrom
cor3ntin:non_type

Conversation

@cor3ntin
Copy link
Contributor

As previously discussed by CWG.
The aim is to editorially adopt some of the wording changes made in P2841R5 to ease its review in core.

Note that not all-instance of non-type have been
mechanically replaced as [dcl] and [diff] use
the term to refer to anything that is not a type
in the context of lookup

As previously discussed by CWG.The aim is to editorially adopt some of the wordingchanges made in P2841R5 to ease its review in core.Note that not all-instance of non-type have beenmechanically replaced as [dcl] and [diff] usethe term to refer to anything that is not a typein the context of lookup
@tkoeppetkoeppe added the cwgIssue must be reviewed by CWG. labelJan 26, 2025
@cor3ntin
Copy link
ContributorAuthor

@jensmaurer Can we make progress on this this week? I am afraid things are going to be rather messy otherwise. Thanks

Copy link
Member

@hubert-reinterpretcasthubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM; thanks!

Copy link
Member

@jensmaurerjensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok for me.

@jensmaurer
Copy link
Member

@tkoeppe , I'd like to merge this ASAP.

@tkoeppe
Copy link
Contributor

All squashed as one commit?

@tkoeppe
Copy link
Contributor

Right after#7485 if that's OK?

@jensmaurer
Copy link
Member

Yes, that needs to be squashed and the commit-message needs to get at least the label [std] or so.
After the other commit is fine, as long as it's happening soon.

@tkoeppetkoeppe merged commit70cec9a intocplusplus:mainFeb 10, 2025
2 checks passed
tkoeppe pushed a commit that referenced this pull requestFeb 10, 2025
)Note that not all instances of "non-type" have been mechanically replaced,as [dcl] and [diff] use the term to refer to anything that is not a typein the context of lookup.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jensmaurerjensmaurerjensmaurer approved these changes

+1 more reviewer

@hubert-reinterpretcasthubert-reinterpretcasthubert-reinterpretcast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tkoeppetkoeppe

Labels

cwgIssue must be reviewed by CWG.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cor3ntin@jensmaurer@tkoeppe@hubert-reinterpretcast
[8]ページ先頭
©2009-2026 Movatter.jp