Movatterモバイル変換

[0]ホーム
URL:

Wayback Machine
2 captures
22 Mar 2019 - 30 Aug 2024
FebMARAug
Previous capture22Next capture
201820192024
success
fail
COLLECTED BY
TIMESTAMPS
loading
The Wayback Machine - https://web.archive.org/web/20190322140838/https://github.com/dotnet/coreclr/pull/22525
Skip to content
Sign in Sign up

/coreclr

Join GitHub today

GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Support building with VS2019 Preview#22525

Merged
tannergooding merged 4 commits intodotnet:masterfromtannergooding:vs2019Feb 12, 2019

Conversation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@tannergooding@jashook@jkotas@TylerBrinkley@sandreenko@safern
@tannergooding
Copy link
Member

tannergooding commentedFeb 11, 2019

Resolves#22446

@@ -13,6 +13,7 @@ You must install several components to build the CoreCLR and CoreFX repos. These
Visual Studio must be installed. Supported versions:
- [Visual Studio 2015](https://www.visualstudio.com/vs/older-downloads/) (Community, Professional, Enterprise). The community version is completely free.
- [Visual Studio 2017](https://www.visualstudio.com/downloads/) (Community, Professional, Enterprise). The community version is completely free.
- [Visual Studio 2019 Preview](https://visualstudio.microsoft.com/vs/preview/) (Community, Professional, Enterprise). The community version is completely free.

This comment has been minimized.

Copy link
@tannergooding

tannergoodingFeb 11, 2019

Author Member

The exact workloads required should probably be figured out. It might be worth updating the VS2017 entries as well (as it specifies more than actually required in the latest release).

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

Worth noting the following warnings:

CMake Deprecation Warning at src/Interop/PInvoke/DllImportPath/CMakeLists.txt:11 (cmake_policy):  The OLD behavior for policy CMP0037 will be removed from a future version  of CMake.  The cmake-policies(7) manual explains that the OLD behaviors of all  policies are deprecated and that a policy should be set to OLD only under  specific short-term circumstances.  Projects should be ported to the NEW  behavior and not rely on setting a policy to OLD.-- Configuring doneCMake Warning in src/Interop/IJW/ManagedCallingNative/IjwNativeDll/CMakeLists.txt:  For the target "IjwNativeDll" the /clr compiler flag was added manually.  Set usage of C++/CLI by setting COMMON_LANGUAGE_RUNTIME target property.CMake Warning in src/Interop/IJW/NativeCallingManaged/IjwNativeCallingManagedDll/CMakeLists.txt:  For the target "IjwNativeCallingManagedDll" the /clr compiler flag was  added manually.  Set usage of C++/CLI by setting COMMON_LANGUAGE_RUNTIME  target property.
@jashook

jashook approved these changesFeb 11, 2019

Copy link
Member

jashook left a comment

lgtm thanks for the change!

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

Seems there is also an error when compiling the tests:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(423,5): error MSB6006: "CL.exe" exited with code -1073740940. [E:\Users\tagoo\Repos\coreclr\bin\tests\obj\Windows_NT.x64.Debug\Native\src\baseservices\exceptions\regressions\Dev11\147911\fpcw.vcxproj]

All other tests compile successfully.

@safern

safern approved these changesFeb 11, 2019

Copy link
Member

safern left a comment

LGTM

@tannergoodingtannergoodingforce-pushed the tannergooding:vs2019branch from444b9ba tob27682eFeb 11, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

@jashook, what would you recommend to deal with the singular test project that fails to compile under VS 2019 (see#22525 (comment))?

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

It might be worth noting that, refactoring the code file (so that each__try/__except block is in its own method) allows the test to compile. This also makes the test more readable given that there are three different "scenarios" being covered by it.

@jashook

This comment has been minimized.

Copy link
Member

jashook commentedFeb 11, 2019

Seems like changing it to allow it to compile seems correct to me. /cc@RussKeldorph opinion?

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 11, 2019

I imagine we will want to log a bug with the VC++ team as well.

Show resolvedHide resolved build-test.cmdOutdated
@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 12, 2019

Added a commit removing the VS2015 support, as per the comment from@jkotas here:#22525 (comment)

I think everything (modulo the VC++ bug, which I am logging now) should be addressed now and this should be ready to merge after the tests complete.

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commentedFeb 12, 2019•
edited

DevDiv#789922 was logged to track the C++ compiler issue that showed up forregressions\Dev11\147911\fpcw

@tannergoodingtannergooding merged commitf077060 intodotnet:masterFeb 12, 2019
25 checks passed

25 checks passed

CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
OSX10.12 x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked crossgen_comparison Build and Test Build finished.
Details
Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Release crossgen_comparison Build and Test Build finished.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT x64 Checked CoreFX Tests Build finished.
Details
Windows_NT x64 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release CoreFX Tests Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Windows_NT x86 Release Innerloop Build and Test Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details
* Ensure you have installed at least [Visual Studio 2015 Update 3](https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update3-vs).
* Make sure that you install "VC++ Tools". By default, they will not be installed.
* To build for Arm32, Make sure that you have the Windows SDK for Windows 10 installed (or selected to be installed as part of VS installation). To explicitly install Windows SDK, download it from here: [Windows SDK for Windows 10](https://developer.microsoft.com/en-us/windows/downloads)
- [Visual Studio 2019 Preview](https://visualstudio.microsoft.com/vs/preview/) (Community, Professional, Enterprise). The community version is completely free.

This comment has been minimized.

Copy link
@TylerBrinkley

TylerBrinkleyMar 13, 2019•
edited

It should have been noted that the CMake version needs to be 3.14-rc for VS 2019.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
You can’t perform that action at this time.
[8]ページ先頭
©2009-2025 Movatter.jp