Movatterモバイル変換


[0]ホーム

URL:


Wayback Machine
1 capture
22 Mar 2019
FebMARApr
Previous capture22Next capture
201820192020
success
fail
COLLECTED BY
TIMESTAMPS
loading
The Wayback Machine - https://web.archive.org/web/20190322195341/https://github.com/dotnet/coreclr/pull/18873
Skip to content
Sign in Sign up

/coreclr

Join GitHub today

GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Add prefix to DAC's PAL exports for alpine#18873

Merged
mikem8361 merged 1 commit intodotnet:masterfrommikem8361:alpinepalJul 13, 2018

Conversation

Assignees

@mikem8361mikem8361

Projects
None yet
Milestone
 2.2.x
5 participants
@mikem8361@nbilling@omajid@noahfalk@chuckries
@mikem8361
Copy link
Member

mikem8361 commentedJul 11, 2018

Added some cmake logic to create assembly include mapping files. One that maps the
prefixed name (DAC_foo) to the actual name (foo) which is included in the DAC module
and another that maps the actual name to the prefixed name that is included in the SOS,
DBI and createdump modules.

The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).

There were some C++ exports functions exported with their decorated names in
the CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. Created
PAL_* style export functions that implements the code.

Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

@mikem8361mikem8361 added this to the2.2 milestoneJul 11, 2018

@mikem8361mikem8361 self-assigned thisJul 11, 2018

@mikem8361mikem8361 requested review fromchuckries andnoahfalkJul 11, 2018

@nbilling

This comment has been minimized.

Copy link

nbilling commentedJul 11, 2018

<--- Nelson's account.

@chuckries

chuckries approved these changesJul 12, 2018

@mikem8361

This comment has been minimized.

Copy link
Member Author

mikem8361 commentedJul 12, 2018

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

@mikem8361
Add prefix to DAC's PAL exports for alpine
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
Loading status checks…

@mikem8361mikem8361force-pushed the mikem8361:alpinepalbranch frome569e23 toa620b50Jul 13, 2018

CatchHardwareExceptionHolder();
CatchHardwareExceptionHolder()
{
PAL_CatchHardwareExceptionHolderEnter();

This comment has been minimized.

Copy link
@noahfalk

noahfalkJul 13, 2018

Member

Does moving these implementations into the header relate to the renaming or is this something else? (not implying you need to move it, just trying to understand)

This comment has been minimized.

Copy link
@mikem8361

mikem8361Jul 13, 2018

Author Member

We were exporting the C++ decorated names for the constructor/destructor and I didn't want to depend on the compiler's name decoration format anymore.

@noahfalk

noahfalk approved these changesJul 13, 2018

Copy link
Member

noahfalk left a comment

LGTM (albeit I'm not an expert by any means in cmake but it seemed reasonable)

@mikem8361mikem8361 merged commitb89e230 intodotnet:masterJul 13, 2018
23 checks passed

23 checks passed

CROSS Check Build finished.
Details
CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
OSX10.12 x64 Checked CoreFX Tests Build finished.
Details
OSX10.12 x64 Checked Innerloop Build and Test Build finished.
Details
Tizen armel Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm64 Cross Debug Innerloop Build Build finished.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
WIP ready for review
Details
Windows_NT x64 Checked CoreFX Tests Build finished.
Details
Windows_NT x64 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x86 Release Innerloop Build and Test Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details

@mikem8361mikem8361 deleted the mikem8361:alpinepalbranchJul 13, 2018

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 13, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 16, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 26, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 30, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestAug 3, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestAug 3, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.

mikem8361 added a commit that referenced this pull requestAug 4, 2018

@mikem8361
Add prefix to DAC's PAL exports for alpine (#18873) (#19198)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
Verified
This commit was created on GitHub.com and signed with averified signature using GitHub’s key.
GPG key ID:4AEE18F83AFDEB23Learn about signing commits

omajid added a commit to omajid/coreclr that referenced this pull requestNov 19, 2018

@omajid
Fix search for headers and libraries via LLVM_HOME
Commitb89e230 (PRdotnet#18873) renamed WITH_LLDB_LIBS to LLDB_LIB_DIR andWITH_LLDB_INCLUDES to LLDB_INCLUDE_DIR. But it forgot to update theusage of these variables in some find_library and find_path calls.As a result, setting LLVM_HOME is no longer enough to compile coreclr onplatforms with non-standard locations for lldb. This commit fixes that.
@omajid

This comment has been minimized.

Copy link
Member

omajid commentedNov 19, 2018

This change introduced a regression when usingLLVM_HOME to specify a non-standard directory for lldb headers. I opened a PR to fix it:#21084

janvorli added a commit that referenced this pull requestNov 20, 2018

@omajid@janvorli
Fix search for headers and libraries via LLVM_HOME (#21084)
Commitb89e230 (PR#18873) renamed WITH_LLDB_LIBS to LLDB_LIB_DIR andWITH_LLDB_INCLUDES to LLDB_INCLUDE_DIR. But it forgot to update theusage of these variables in some find_library and find_path calls.As a result, setting LLVM_HOME is no longer enough to compile coreclr onplatforms with non-standard locations for lldb. This commit fixes that.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
You can’t perform that action at this time.

[8]ページ先頭

©2009-2025 Movatter.jp