Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upNew issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add prefix to DAC's PAL exports for alpine#18873
Conversation
Added some cmake logic to create assembly include mapping files. One that maps the The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data). There were some C++ exports functions exported with their decorated names in Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it. |
mikem8361 added thearea-Diagnostics labelJul 11, 2018
mikem8361 added this to the2.2 milestoneJul 11, 2018
mikem8361 self-assigned thisJul 11, 2018
mikem8361 requested review fromchuckries andnoahfalkJul 11, 2018
This comment has been minimized.
This comment has been minimized.
nbilling commentedJul 11, 2018
<--- Nelson's account. |
chuckries approved these changesJul 12, 2018
This comment has been minimized.
This comment has been minimized.
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
Add prefix to DAC's PAL exports for alpine
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361force-pushed the mikem8361:alpinepalbranch frome569e23
toa620b50
Jul 13, 2018
noahfalk reviewedJul 13, 2018
CatchHardwareExceptionHolder(); | ||
CatchHardwareExceptionHolder() | ||
{ | ||
PAL_CatchHardwareExceptionHolderEnter(); |
This comment has been minimized.
This comment has been minimized.
noahfalkJul 13, 2018
MemberDoes moving these implementations into the header relate to the renaming or is this something else? (not implying you need to move it, just trying to understand)
This comment has been minimized.
This comment has been minimized.
mikem8361Jul 13, 2018
Author MemberWe were exporting the C++ decorated names for the constructor/destructor and I didn't want to depend on the compiler's name decoration format anymore.
noahfalk approved these changesJul 13, 2018
LGTM (albeit I'm not an expert by any means in cmake but it seemed reasonable) |
mikem8361 merged commitb89e230
intodotnet:masterJul 13, 2018 23 checks passed
23 checks passed
mikem8361 deleted the mikem8361:alpinepalbranchJul 13, 2018
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 13, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 referenced this pull requestJul 13, 2018
ClosedAlpine Linux coreclr, dac, dbi not honoring PAL symbol versions#18307
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 16, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 26, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestJul 30, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestAug 3, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 added a commit to mikem8361/coreclr that referenced this pull requestAug 3, 2018
Add prefix to DAC's PAL exports for alpine (dotnet#18873)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
mikem8361 added a commit that referenced this pull requestAug 4, 2018
Add prefix to DAC's PAL exports for alpine (#18873) (#19198)
Added some cmake logic to create assembly include mapping files. One that maps theprefixed name (DAC_foo) to the actual name (foo) which is included in the DAC moduleand another that maps the actual name to the prefixed name that is included in the SOS,DBI and createdump modules.The data exports like IID_IUnknown are not prefixed and don't need to be (immutable static data).There were some C++ exports functions exported with their decorated names inthe CatchHardwareExceptionHolder and NativeExceptionHolderBase classes. CreatedPAL_* style export functions that implements the code.Fix lldb plugin cmake file to use LLDB_H/LLDB_LIB env vars to build it.
Verified
kevingosse referenced this pull requestNov 13, 2018
ClosedFailure to get address of DAC_PAL_InitializeDLL on custom centos build#141
omajid added a commit to omajid/coreclr that referenced this pull requestNov 19, 2018
Fix search for headers and libraries via LLVM_HOME
Commitb89e230 (PRdotnet#18873) renamed WITH_LLDB_LIBS to LLDB_LIB_DIR andWITH_LLDB_INCLUDES to LLDB_INCLUDE_DIR. But it forgot to update theusage of these variables in some find_library and find_path calls.As a result, setting LLVM_HOME is no longer enough to compile coreclr onplatforms with non-standard locations for lldb. This commit fixes that.
omajid referenced this pull requestNov 19, 2018
MergedFix search for headers and libraries via LLVM_HOME#21084
This comment has been minimized.
This comment has been minimized.
This change introduced a regression when using |
janvorli added a commit that referenced this pull requestNov 20, 2018
Fix search for headers and libraries via LLVM_HOME (#21084)
Commitb89e230 (PR#18873) renamed WITH_LLDB_LIBS to LLDB_LIB_DIR andWITH_LLDB_INCLUDES to LLDB_INCLUDE_DIR. But it forgot to update theusage of these variables in some find_library and find_path calls.As a result, setting LLVM_HOME is no longer enough to compile coreclr onplatforms with non-standard locations for lldb. This commit fixes that.