Movatterモバイル変換


[0]ホーム

URL:


Wayback Machine
2 captures
20 Jun 2025 - 21 Jun 2025
MayJUNJul
Previous capture20Next capture
202420252026
success
fail
COLLECTED BY
Collection:Save Page Now
TIMESTAMPS
loading
The Wayback Machine - https://web.archive.org/web/20250620041348/https://github.com/python/cpython/pull/3385
Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-31370: Remove support for threads-less builds#3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 10 commits intopython:masterfrompitrou:always_threads
Sep 7, 2017

Conversation

pitrou
Copy link
Member

@pitroupitrou commentedSep 6, 2017
edited by bedevere-bot
Loading

Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yay! i skimmed over everything, it looks good. lots of mechanical changes. :)

@pitroupitrou changed the title[WIP] Remove support for threads-less builds[WIP] bpo-31370: Remove support for threads-less buildsSep 6, 2017
@pitroupitrou changed the title[WIP] bpo-31370: Remove support for threads-less buildsbpo-31370: Remove support for threads-less buildsSep 6, 2017
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please keep the "#define WITH_THREAD 1" for backward compatibily. Maybe in pyport.h?

LGTM if you keep the define, but I would like to see a review of another core dev like@ericsnowcurrently.

Seehttps://bugs.python.org/issue27961#msg276881 and commita251fb0.

Copy link
Member

@bitdancerbitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The test_email change looks fine :)

I think this needs a mention in What's New as well.

@pitroupitrou requested a review froma team as acode ownerSeptember 7, 2017 10:41
@pitrou
Copy link
MemberAuthor

Please keep the "#define WITH_THREAD 1" for backward compatibily. Maybe in pyport.h?

Ok, done.

@pitrou
Copy link
MemberAuthor

I think this needs a mention in What's New as well.

Ok, done.

@vstinnervstinner merged commita6a4dc8 intopython:masterSep 7, 2017
@vstinner
Copy link
Member

Thanks, I merged your change ;-)

@mscuthbert
Copy link

mscuthbert commentedSep 8, 2017
edited
Loading

Ignore below; forgot to copy Modules/Setup.dist to Modules/Setup

Anyone else getting this error when trying to build Python on OS X after the merge?

File "/Users/cuthbert/git/cpython/Lib/reprlib.py", line 7, in <module>    from _thread import get_identModuleNotFoundError: No module named '_thread'

It seems that_thread is no longer being made in the build process.

Full part of the make process:

./python.exe -E -S -m sysconfig --generate-posix-vars ;\if test $? -ne 0 ; then \echo "generate-posix-vars failed" ; \rm -f ./pybuilddir.txt ; \exit 1 ; \fiCould not import runpy moduleTraceback (most recent call last):  File "/Users/cuthbert/git/cpython/Lib/runpy.py", line 14, in <module>    import importlib.machinery # importlib first so we can test #15386 via -m  File "/Users/cuthbert/git/cpython/Lib/importlib/__init__.py", line 57, in <module>    import types  File "/Users/cuthbert/git/cpython/Lib/types.py", line 175, in <module>    import functools as _functools  File "/Users/cuthbert/git/cpython/Lib/functools.py", line 21, in <module>    from collections import namedtuple  File "/Users/cuthbert/git/cpython/Lib/collections/__init__.py", line 32, in <module>    from reprlib import recursive_repr as _recursive_repr  File "/Users/cuthbert/git/cpython/Lib/reprlib.py", line 7, in <module>    from _thread import get_identModuleNotFoundError: No module named '_thread'

ma8ma added a commit to ma8ma/cpython that referenced this pull requestSep 8, 2017
Resolve conflicts:a6a4dc8 bpo-31370: Remove support for threads-less builds (python#3385)
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull requestApr 13, 2024
* Remove Setup.config* Always define WITH_THREAD for compatibility.
cjwatson added a commit to cjwatson/pastescript that referenced this pull requestDec 8, 2024
python/cpython#109462 removed`logging._acquireLock`.  Fortunately,python/cpython#3385 simplified lock creation sothat `with logging._lock:` is sufficient; that PR made it into Python3.7, which is already pastescript's minimum Python requirement.
cdent pushed a commit to pasteorg/pastescript that referenced this pull requestJan 22, 2025
python/cpython#109462 removed`logging._acquireLock`.  Fortunately,python/cpython#3385 simplified lock creation sothat `with logging._lock:` is sufficient; that PR made it into Python3.7, which is already pastescript's minimum Python requirement.
jjhelmus added a commit to jjhelmus/conda that referenced this pull requestFeb 11, 2025
Aquire the logging lock using the underlying _lock object from thelogging module.As ofpython/cpython#3385, included in Python 3.7, this object an instanceof threading.RLock whose use as a context manager with release beingcalled when the block exits, seehttps://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement
jezdez pushed a commit to conda/conda that referenced this pull requestFeb 12, 2025
* aquire logging lock using _lock context managerAquire the logging lock using the underlying _lock object from thelogging module.As ofpython/cpython#3385, included in Python 3.7, this object an instanceof threading.RLock whose use as a context manager with release beingcalled when the block exits, seehttps://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement* mark conda.common.io._logger_lock for deprecation* add news* Update news/14584-use-logging-lock* Apply suggestions from code review---------Co-authored-by: Daniel Holth <dholth@anaconda.com>Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bitdancerbitdancerbitdancer left review comments

@gpsheadgpsheadgpshead approved these changes

@vstinnervstinnervstinner approved these changes

@1st11st1Awaiting requested review from 1st1

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@rhettingerrhettingerAwaiting requested review from rhettinger

@skrahskrahAwaiting requested review from skrah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@pitrou@vstinner@mscuthbert@gpshead@bitdancer@Mariatta@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp