Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(postgres): enum with string COMMENT breaks query#9891

Merged
sushantdhiman merged 1 commit intomasterfrom
fix-comment-enum-case
Sep 8, 2018
Merged

fix(postgres): enum with string COMMENT breaks query#9891
sushantdhiman merged 1 commit intomasterfrom
fix-comment-enum-case

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Doesnpm run test ornpm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained inCONTRIBUTING.md?

Description of change

Fixes#9149

Added a space inindexOf check, enum withCOMMENT is common butCOMMENT<space> should be rare or invalid for most use cases, just enough to fix this bug

@codecov
Copy link

codecovbot commentedSep 8, 2018

Codecov Report

Merging#9891 intomaster willnot change coverage.
The diff coverage is100%.

@sushantdhimansushantdhiman merged commit03155ad intomasterSep 8, 2018
@sushantdhimansushantdhiman deleted the fix-comment-enum-case branchSeptember 8, 2018 07:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sequelize.ENUM does not support the substring COMMENT

1 participant

@sushantdhiman

[8]ページ先頭

©2009-2026 Movatter.jp