refactor: reduce code complexity#10120

Merged

sushantdhiman merged 1 commit intosequelize:masterfrom

SimonSchick:chore/optimize-2

Nov 12, 2018

Merged

refactor: reduce code complexity#10120
sushantdhiman merged 1 commit intosequelize:masterfrom
SimonSchick:chore/optimize-2

Conversation

Copy link

Contributor

SimonSchick commentedNov 4, 2018•
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

Doesnpm run test ornpm run test-DIALECT pass with this change (including linting)?
Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
Have you added new tests to prevent regressions?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Did you follow the commit message conventions explained inCONTRIBUTING.md?

Description of change

Cleanups remainingelse (if)'s with linter help.
Fixed various lint warnings and made them errors so they don't come back
Removed some dead node 0.10.x support snippet
Replace.npmignore withfiles inpackage.json and exclude all redundant files for use.

On another note, is there a reason you callError.captureStackTrace(this, this.constructor); on all error errors?
Are you doing to to prevent it from capturing the first stack frame?

This will be my last code cleanup PR until v5 is out.

Copy link

codecovbot commentedNov 4, 2018•
edited
Loading

Codecov Report

Merging#10120 intomaster willincrease coverage by0.01%.
The diff coverage is86.72%.

@@            Coverage Diff             @@##           master   #10120      +/-   ##==========================================+ Coverage   96.33%   96.35%   +0.01%==========================================  Files          63       63                Lines        9431     9426       -5     ==========================================- Hits         9085     9082       -3+ Misses        346      344       -2

Impacted Files	Coverage Δ
lib/associations/belongs-to-many.js	`97.68% <0%> (+0.64%)`	⬆️
lib/query-interface.js	`89.56% <0%> (ø)`	⬆️
lib/dialects/abstract/connection-manager.js	`90% <100%> (ø)`	⬆️
lib/dialects/mssql/query-generator.js	`95.83% <100%> (ø)`	⬆️
lib/associations/has-many.js	`97.64% <100%> (-0.03%)`	⬇️
lib/dialects/sqlite/query-interface.js	`100% <100%> (ø)`	⬆️
lib/utils/validator-extras.js	`97.56% <100%> (ø)`	⬆️
lib/dialects/sqlite/query.js	`98.75% <100%> (ø)`	⬆️
lib/sql-string.js	`91.17% <100%> (ø)`	⬆️
...dialects/abstract/query-generator/helpers/quote.js	`94.44% <100%> (ø)`	⬆️
... and14 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb896ba4...76231aa. Read thecomment docs.