Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-modal): fix scroll to top issue when modal hasno-fade
set (closes #4003)#4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
no-fade
setno-fade
set (closes #4003)codecovbot commentedSep 3, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #4004 +/- ##==========================================+ Coverage 99.86% 99.86% +<.01%========================================== Files 238 238 Lines 4453 4454 +1 Branches 1252 1252 ==========================================+ Hits 4447 4448 +1 Misses 5 5 Partials 1 1
Continue to review full report at Codecov.
|
no-fade
set (closes #4003)no-fade
set (closes #4003)
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
This PR fixes the order/timing of when
sctollTop = 0
happens,Closes#4003
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc).This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: