Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-modal): fix scroll to top issue when modal hasno-fade set (closes #4003)#4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tmorehouse merged 2 commits intodevfromissue/4003
Sep 3, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehousetmorehouse commentedSep 3, 2019
edited
Loading

Describe the PR

This PR fixes the order/timing of whensctollTop = 0 happens,

Closes#4003

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc).This is very important, as theCHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component'spackage.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehousetmorehouse changed the titlefix(modal): fix scroll to top issue when modal hasno-fade setfix(modal): fix scroll to top issue when modal hasno-fade set (closes #4003)Sep 3, 2019
@codecov
Copy link

codecovbot commentedSep 3, 2019
edited
Loading

Codecov Report

Merging#4004 intodev willincrease coverage by<.01%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff             @@##              dev    #4004      +/-   ##==========================================+ Coverage   99.86%   99.86%   +<.01%==========================================  Files         238      238                Lines        4453     4454       +1       Branches     1252     1252              ==========================================+ Hits         4447     4448       +1  Misses          5        5                Partials        1        1
Impacted FilesCoverage Δ
src/components/modal/modal.js99.59% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3aa78fd...aea02f3. Read thecomment docs.

@tmorehousetmorehouse marked this pull request as ready for reviewSeptember 3, 2019 15:32
@tmorehousetmorehouse changed the titlefix(modal): fix scroll to top issue when modal hasno-fade set (closes #4003)fix(b-modal): fix scroll to top issue when modal hasno-fade set (closes #4003)Sep 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jacobmllr95jacobmllr95jacobmllr95 approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Page scroll issue with modals with overflowing content when animation is disabled

2 participants

@tmorehouse@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp