Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapperdiv (closes #3896)#3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jacobmllr95 merged 2 commits intodevfromtmorehouse/modal-attrs
Aug 21, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehousetmorehouse commentedAug 20, 2019
edited by jacobmllr95
Loading

Describe the PR

When the modal was not instatic mode, any additional attributes were not rendering on the modal wrapper div (instead they were being applied to the BTransporter component)

This PR ensures that the attributes are always transferred to the wrapper DIV.

Closes#3896.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc).This is very important, as theCHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component'spackage.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehousetmorehouse changed the titlefix(b-modal): ensure attributes are transferred to the modal outer wrapper divfix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapperdivAug 20, 2019
@codecov
Copy link

codecovbot commentedAug 20, 2019
edited
Loading

Codecov Report

Merging#3921 intodev willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##              dev    #3921   +/-   ##=======================================  Coverage   99.33%   99.33%           =======================================  Files         233      233             Lines        4495     4495             Branches     1271     1271           =======================================  Hits         4465     4465             Misses         24       24             Partials        6        6
Impacted FilesCoverage Δ
src/components/modal/modal.js99.57% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea392059...93d9319. Read thecomment docs.

@jacobmllr95jacobmllr95 changed the titlefix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapperdivfix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapperdiv (closes #3896)Aug 21, 2019
@jacobmllr95jacobmllr95 merged commit8bf3a55 intodevAug 21, 2019
@jacobmllr95jacobmllr95 deleted the tmorehouse/modal-attrs branchAugust 21, 2019 05:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jacobmllr95jacobmllr95jacobmllr95 approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

no way to add data-* attribute to OK button in modal

2 participants

@tmorehouse@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp