Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-modal): ensure non-prop attributes are transferred to the modal outer wrapperdiv
(closes #3896)#3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
div
codecovbot commentedAug 20, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #3921 +/- ##======================================= Coverage 99.33% 99.33% ======================================= Files 233 233 Lines 4495 4495 Branches 1271 1271 ======================================= Hits 4465 4465 Misses 24 24 Partials 6 6
Continue to review full report at Codecov.
|
div
div
(closes #3896)
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
When the modal was not in
static
mode, any additional attributes were not rendering on the modal wrapper div (instead they were being applied to the BTransporter component)This PR ensures that the attributes are always transferred to the wrapper DIV.
Closes#3896.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc).This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: