Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.3k
Add benchmarks for categories: serialization, validation and schema generation#10240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add benchmarks for categories: serialization, validation and schema generation#10240
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codspeed-hqbot commentedAug 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#10240 willnot alter performanceComparing Summary
Benchmarks breakdown
|
AdolfoVillalobos commentedAug 27, 2024
I'm lost as to why the tests are failing. I can't see how my code is impacting them. I would really appreciate some advice ;) Thanks! |
Viicos commentedAug 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for taking a stab at this. Regarding the benchmarks related to core schema generation, I'll probably expand these to meet my needs (related to#10223). I'll make sure to add you as a co-author. |
sydney-runkle commentedAug 27, 2024
Hmm, test failure does seem odd. @AdolfoVillalobos, amazing work here - thanks for helping us to expand our benchmarks! |
sydney-runkle commentedAug 27, 2024
So odd, I can't repo that test failure locally, even when pulling your changes |
sydney-runkle left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll investigate this test failure on a separate branch, but have pushed a patch fix for now.
AdolfoVillalobos commentedAug 28, 2024
I'm glad this PR was helpful ;) Thanks! |
AdolfoVillalobos commentedAug 28, 2024
Yess, it was a bit odd. I still don't quite get what was broken. In any case, thanks for the help and support ;). I love this project; It has helped me many times, so I am happy and proud to make my first contribution. Hopefully, I will continue to contribute in the future ;) |
Uh oh!
There was an error while loading.Please reload this page.
Change Summary
I created three tests to benchmark Pydantic's performance in basic categories:
The tests handle varying levels of complexity ranging from simple tests to nested scenarios, inspired by the pydantic-core test suite.
Related issue number
Contributes to#9711
Checklist