Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/nxPublic

feat(bundling): generate matching d.ts files for rollup#18342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
meeroslav merged 2 commits intonrwl:masterfromjaysoo:feat/rollup-dts
Jul 28, 2023

Conversation

jaysoo
Copy link
Member

@jaysoojaysoo commentedJul 27, 2023
edited
Loading

This PR updates the rollup executor such that it produces.d.ts files matching the output bundle.

It also:

  1. Use[name].esm.js and[name].cjs.js naming convention so Node/TSC doesn't have problems matching CJS files with their.d.ts file -- subsequent requires/imports from.cjs requires file extension to be included, which puts the burden on lib authors.
  2. Updates theexports field to align with current best practice (import +default, notypes)
  3. Generates types still when SWC is used

So a user using dual formats will see:

{"exports":{"./package.json":"./package.json",".":{"import":"./index.esm.js","default":"./index.cjs.js"}}

The types are inferred from file names e.g.index.cjs.d.ts orindex.esm.d.ts.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Chanki-Min reacted with thumbs up emoji
@vercel
Copy link

vercelbot commentedJul 27, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nx-dev✅ Ready (Inspect)Visit Preview💬Add feedbackJul 28, 2023 2:13am

@nx-cloud
Copy link
Contributor

nx-cloudbot commentedJul 27, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb7cea47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 fromNxCloud.

@jaysoojaysoo marked this pull request as ready for reviewJuly 27, 2023 14:18
@jaysoojaysoo requested a review froma team as acode ownerJuly 27, 2023 14:18
@jaysoojaysooforce-pushed thefeat/rollup-dts branch 2 times, most recently froma6a74a5 to8076507CompareJuly 27, 2023 15:36
@jaysoojaysoo requested a review froma team as acode ownerJuly 27, 2023 15:36
@jaysoojaysoo requested a review froma team as acode ownerJuly 27, 2023 16:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ndcunninghamndcunninghamndcunningham approved these changes

@meeroslavmeeroslavAwaiting requested review from meeroslavmeeroslav is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jaysoo@ndcunningham@meeroslav

[8]ページ先頭

©2009-2025 Movatter.jp