Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nxPublic

fix(core): eslint dep check rule should check prereleases correctly#18317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
meeroslav merged 1 commit intonrwl:masterfromColy010:fix/dependency-check-rule
Jul 27, 2023

Conversation

Coly010
Copy link
Contributor

Current Behavior

The dep check rule does not check pre-releases correctly

This surfaced with#17879
You can see the error here:https://staging.nx.app/runs/21ueB3TkiN/task/angular%3lint
The package versions are here:

"@schematics/angular":">= 14.0.0 < 17.0.0",

Expected Behavior

Pre-release version should be picked up correctly

Related Issue(s)

Fixes #

@Coly010Coly010 requested a review froma team as acode ownerJuly 26, 2023 10:15
@Coly010Coly010 added the scope: corecore nx functionality labelJul 26, 2023
@Coly010Coly010 self-assigned thisJul 26, 2023
@Coly010Coly010 requested a review frommeeroslavJuly 26, 2023 10:15
@vercel
Copy link

vercelbot commentedJul 26, 2023•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nx-dev✅ Ready (Inspect)Visit Preview💬Add feedbackJul 27, 2023 11:31am

@nx-cloud
Copy link
Contributor

nx-cloudbot commentedJul 26, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4d28210. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 fromNxCloud.

Copy link
Contributor

@meeroslavmeeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! LGTM

@meeroslavmeeroslavenabled auto-merge (squash)July 26, 2023 10:27
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@meeroslavmeeroslavmeeroslav approved these changes

@FrozenPandazFrozenPandazAwaiting requested review from FrozenPandazFrozenPandaz is a code owner automatically assigned from nrwl/nx-linter-reviewers

Assignees

@Coly010Coly010

Labels
scope: corecore nx functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Coly010@meeroslav
[8]ページ先頭
©2009-2025 Movatter.jp