Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nxPublic

fix(angular): adds missing types in the schemes ofremote andhost generators#11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Coly010 merged 1 commit intonrwl:masterfromIKatsuba:missing-types
Aug 19, 2022

Conversation

IKatsuba
Copy link
Contributor

Current Behavior

I have created a new workspace generator:

import{formatFiles,installPackagesTask,Tree}from'@nrwl/devkit';import{libraryGenerator}from'@nrwl/angular/generators';exportdefaultasyncfunction(tree:Tree,schema:any){awaitlibraryGenerator(tree,{name:schema.name,});awaitformatFiles(tree);return()=>{installPackagesTask(tree);};}

When I run it I get an error:

❯ nx workspace-generator web-pagenode_modules/@nrwl/angular/src/generators/host/schema.d.ts:10:11 - error TS2304: Cannot find name 'Styles'.10   style?: Styles;             ~~~~~~node_modules/@nrwl/angular/src/generators/host/schema.d.ts:14:12 - error TS2304: Cannot find name 'AngularLinter'.14   linter?: AngularLinter;              ~~~~~~~~~~~~~node_modules/@nrwl/angular/src/generators/host/schema.d.ts:15:20 - error TS2304: Cannot find name 'UnitTestRunner'.15   unitTestRunner?: UnitTestRunner;                      ~~~~~~~~~~~~~~node_modules/@nrwl/angular/src/generators/host/schema.d.ts:16:19 - error TS2304: Cannot find name 'E2eTestRunner'.16   e2eTestRunner?: E2eTestRunner;                     ~~~~~~~~~~~~~node_modules/@nrwl/angular/src/generators/remote/schema.d.ts:9:11 - error TS2304: Cannot find name 'Styles'.9   style?: Styles;            ~~~~~~node_modules/@nrwl/angular/src/generators/remote/schema.d.ts:13:12 - error TS2304: Cannot find name 'AngularLinter'.13   linter?: AngularLinter;              ~~~~~~~~~~~~~node_modules/@nrwl/angular/src/generators/remote/schema.d.ts:14:20 - error TS2304: Cannot find name 'UnitTestRunner'.14   unitTestRunner?: UnitTestRunner;                      ~~~~~~~~~~~~~~node_modules/@nrwl/angular/src/generators/remote/schema.d.ts:15:19 - error TS2304: Cannot find name 'E2eTestRunner'.15   e2eTestRunner?: E2eTestRunner;                     ~~~~~~~~~~~~~Found 8 errors in 2 files.Errors  Files     4  node_modules/@nrwl/angular/src/generators/host/schema.d.ts:10     4  node_modules/@nrwl/angular/src/generators/remote/schema.d.ts:9

Expected Behavior

New generator works fine.

Related Issue(s)

Fixes #

@nx-cloud-staging
Copy link

nx-cloud-stagingbot commentedAug 3, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd0f50f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 12 targets

Sent with 💌 fromNxCloud.

@vercel
Copy link

vercelbot commentedAug 3, 2022•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewUpdated
nx-dev⬜️ Ignored (Inspect)Aug 3, 2022 at 2:23PM (UTC)

Copy link
Contributor

@Coly010Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Incredible, thanks for this!

IKatsuba and MariannaSpb reacted with heart emoji
@Coly010Coly010 merged commit9294b64 intonrwl:masterAug 19, 2022
@IKatsubaIKatsuba deleted the missing-types branchAugust 19, 2022 09:10
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Coly010Coly010Coly010 approved these changes

Assignees

@Coly010Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@IKatsuba@Coly010
[8]ページ先頭
©2009-2025 Movatter.jp